Add unittests checking that old saved session can be restored.

Add unittests checking that old saved session can be restored.

The session serialisation code has support for converting a
serialised session from an old format to the new one when a
class is renamed or a property is moved so add unittests to
check the conversion works properly by loading old sessions.

Clean up the code to use proper idioms (use leading underscore
for Objective-C ivar, use macro to mark designated initialiser,
remove redundant ivar backing synthesised property, ...).

BUG=698750
Review-Url: https://codereview.chromium.org/2732063003
Cr-Commit-Position: refs/heads/master@{#455217}
Committed: https://chromium.googlesource.com/chromium/src/+/88d556703b1fbb2b53fa3d90c4938ee93ba3a8c1

[sdefresne, 2017-03-07 01:55:01]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2017-03-07 01:55:16]

sdefresne@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[sdefresne, 2017-03-07 01:55:16]

Please take a look.

[commit-bot: I haz the power, 2017-03-07 01:55:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 03:49:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 03:49:09]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kkhorimoto, 2017-03-07 05:13:53]

lgtm

https://codereview.chromium.org/2732063003/diff/1/ios/chrome/browser/sessions...
File ios/chrome/browser/sessions/session_service.mm (right):

https://codereview.chromium.org/2732063003/diff/1/ios/chrome/browser/sessions...
ios/chrome/browser/sessions/session_service.mm:103: -
(void)performSaveToDirectoryInBackground:(NSString*)directory;
Since we're cleaning up this class, can you add a comment to this declaration?

[sdefresne, 2017-03-07 17:58:17]

Thank you for the review.

https://codereview.chromium.org/2732063003/diff/1/ios/chrome/browser/sessions...
File ios/chrome/browser/sessions/session_service.mm (right):

https://codereview.chromium.org/2732063003/diff/1/ios/chrome/browser/sessions...
ios/chrome/browser/sessions/session_service.mm:103: -
(void)performSaveToDirectoryInBackground:(NSString*)directory;
On 2017/03/07 05:13:53, kkhorimoto_ wrote:
> Since we're cleaning up this class, can you add a comment to this declaration?

Done.

[sdefresne, 2017-03-07 17:58:30]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2017-03-07 17:58:31]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-03-07 17:58:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
kkhorimoto@chromium.org
Link to the patchset: https://codereview.chromium.org/2732063003/#ps20001
(title: "Document -performSaveToDirectoryInBackground:.")

[commit-bot: I haz the power, 2017-03-07 18:00:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 21:02:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488909511376680,
"parent_rev": "cc57c4542797ff0baa5a28e21acfd32fa4863c46", "commit_rev":
"88d556703b1fbb2b53fa3d90c4938ee93ba3a8c1"}

[commit-bot: I haz the power, 2017-03-07 22:30:06]

Description was changed from

==========
Add unittests checking that old saved session can be restored.

The session serialisation code has support for converting a
serialised session from an old format to the new one when a
class is renamed or a property is moved so add unittests to
check the conversion works properly by loading old sessions.

Clean up the code to use proper idioms (use leading underscore
for Objective-C ivar, use macro to mark designated initialiser,
remove redundant ivar backing synthesised property, ...).

BUG=698750
==========

to

==========
Add unittests checking that old saved session can be restored.

The session serialisation code has support for converting a
serialised session from an old format to the new one when a
class is renamed or a property is moved so add unittests to
check the conversion works properly by loading old sessions.

Clean up the code to use proper idioms (use leading underscore
for Objective-C ivar, use macro to mark designated initialiser,
remove redundant ivar backing synthesised property, ...).

BUG=698750

Review-Url: https://codereview.chromium.org/2732063003
Cr-Commit-Position: refs/heads/master@{#455217}
Committed:
https://chromium.googlesource.com/chromium/src/+/88d556703b1fbb2b53fa3d90c493...
==========

[commit-bot: I haz the power, 2017-03-07 22:30:07]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/88d556703b1fbb2b53fa3d90c493...