Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2687353003: Created SerializableUserDataManager. (Closed)

Created:
3 years, 10 months ago by kkhorimoto
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Created SerializableUserDataManager. This class allows the persistence of arbitrary user data attached to a WebState. This CL also renames CRWNavigationManagerStorage to CRWSessionStorage and updates its associated builder class interface to use WebStates instead of NavigationManagerImpls. BUG=454984 Review-Url: https://codereview.chromium.org/2687353003 Cr-Commit-Position: refs/heads/master@{#449843} Committed: https://chromium.googlesource.com/chromium/src/+/5237846c806ca677f5bca846e931dfa29428866b

Patch Set 1 #

Patch Set 2 : self review, added unittest #

Total comments: 10

Patch Set 3 : Eugene's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+448 lines, -346 lines) Patch
M ios/chrome/browser/crash_report/crash_restore_helper.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sessions/session_service.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/sessions/session_window.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/sessions/session_window.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/sessions/session_window_unittest.mm View 1 2 4 chunks +7 lines, -11 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model_unittest.mm View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/BUILD.gn View 1 4 chunks +8 lines, -4 lines 0 comments Download
M ios/web/navigation/crw_session_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/navigation/navigation_manager_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
D ios/web/navigation/navigation_manager_storage_builder.h View 1 chunk +0 lines, -29 lines 0 comments Download
D ios/web/navigation/navigation_manager_storage_builder.mm View 1 chunk +0 lines, -104 lines 0 comments Download
A ios/web/navigation/serializable_user_data_manager_impl.h View 1 2 1 chunk +53 lines, -0 lines 0 comments Download
A ios/web/navigation/serializable_user_data_manager_impl.mm View 1 chunk +117 lines, -0 lines 0 comments Download
A ios/web/navigation/session_storage_builder.h View 1 chunk +28 lines, -0 lines 0 comments Download
A + ios/web/navigation/session_storage_builder.mm View 1 5 chunks +34 lines, -30 lines 0 comments Download
D ios/web/public/crw_navigation_manager_storage.h View 1 chunk +0 lines, -31 lines 0 comments Download
D ios/web/public/crw_navigation_manager_storage.mm View 1 chunk +0 lines, -88 lines 0 comments Download
A + ios/web/public/crw_session_storage.h View 2 chunks +15 lines, -6 lines 0 comments Download
A + ios/web/public/crw_session_storage.mm View 5 chunks +27 lines, -2 lines 0 comments Download
A ios/web/public/serializable_user_data_manager.h View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
A ios/web/public/serializable_user_data_manager_unittest.mm View 1 2 1 chunk +64 lines, -0 lines 0 comments Download
M ios/web/public/test/fakes/test_web_state.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/test/fakes/test_web_state.mm View 1 1 chunk +1 line, -1 line 0 comments Download
M ios/web/public/web_state/web_state.h View 1 3 chunks +5 lines, -6 lines 0 comments Download
M ios/web/web_state/web_state_impl.h View 1 4 chunks +7 lines, -4 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 5 chunks +10 lines, -12 lines 0 comments Download

Dependent Patchsets:

Issue 2693523003 Patch 1
Issue 2693523003 Patch 20001

Messages

Total messages: 10 (5 generated)
kkhorimoto
3 years, 10 months ago (2017-02-11 02:15:35 UTC) #2
Eugene But (OOO till 7-30)
lgtm https://codereview.chromium.org/2687353003/diff/20001/ios/chrome/browser/sessions/session_window.h File ios/chrome/browser/sessions/session_window.h (right): https://codereview.chromium.org/2687353003/diff/20001/ios/chrome/browser/sessions/session_window.h#newcode27 ios/chrome/browser/sessions/session_window.h:27: - (void)addSerializedSession:(CRWSessionStorage*)session; Is this final API? If so ...
3 years, 10 months ago (2017-02-11 02:46:48 UTC) #3
kkhorimoto
https://codereview.chromium.org/2687353003/diff/20001/ios/chrome/browser/sessions/session_window.h File ios/chrome/browser/sessions/session_window.h (right): https://codereview.chromium.org/2687353003/diff/20001/ios/chrome/browser/sessions/session_window.h#newcode27 ios/chrome/browser/sessions/session_window.h:27: - (void)addSerializedSession:(CRWSessionStorage*)session; On 2017/02/11 02:46:48, Eugene But wrote: > ...
3 years, 10 months ago (2017-02-11 03:19:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2687353003/40001
3 years, 10 months ago (2017-02-11 03:20:18 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 04:54:33 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5237846c806ca677f5bca846e931...

Powered by Google App Engine
This is Rietveld 408576698