[debug] add exception predictions to builtins where missing.

[debug] add exception predictions to builtins where missing.

R=gsathya@chromium.org, jgruber@chromium.org
BUG=chromium:691875

[Yang, 2017-03-06 11:45:02]

Sathya, would you like to take this over?

https://codereview.chromium.org/2731273002/diff/1/src/builtins/builtins-promi...
File src/builtins/builtins-promise.cc (right):

https://codereview.chromium.org/2731273002/diff/1/src/builtins/builtins-promi...
src/builtins/builtins-promise.cc:833: InternalPromiseReject(context, promise,
var_reason.value(), false);
In the test case we break twice, once in the getter where we throw the
exception, and a second time in Promise.resolve itself, where we trigger a
PromiseReject event. The PromiseReject event is redundant.

https://codereview.chromium.org/2731273002/diff/1/test/cctest/test-debug.cc
File test/cctest/test-debug.cc (right):

https://codereview.chromium.org/2731273002/diff/1/test/cctest/test-debug.cc#n...
test/cctest/test-debug.cc:6675: i::PrintF("%s is missing exception
predictions.\n", builtins->name(i));
The output of this is currently:

ResolvePromise is missing exception predictions.
PromiseResolve is missing exception predictions.
PromiseThenFinally is missing exception predictions.
PromiseCatchFinally is missing exception predictions.
AsyncFromSyncIteratorPrototypeNext is missing exception predictions.
AsyncFromSyncIteratorPrototypeThrow is missing exception predictions.
AsyncFromSyncIteratorPrototypeReturn is missing exception predictions.

[gsathya, 2017-03-06 20:46:52]

On 2017/03/06 11:45:02, Yang wrote:
> Sathya, would you like to take this over?
> 
>
https://codereview.chromium.org/2731273002/diff/1/src/builtins/builtins-promi...
> File src/builtins/builtins-promise.cc (right):
> 
>
https://codereview.chromium.org/2731273002/diff/1/src/builtins/builtins-promi...
> src/builtins/builtins-promise.cc:833: InternalPromiseReject(context, promise,
> var_reason.value(), false);
> In the test case we break twice, once in the getter where we throw the
> exception, and a second time in Promise.resolve itself, where we trigger a
> PromiseReject event. The PromiseReject event is redundant.
> 
> https://codereview.chromium.org/2731273002/diff/1/test/cctest/test-debug.cc
> File test/cctest/test-debug.cc (right):
> 
>
https://codereview.chromium.org/2731273002/diff/1/test/cctest/test-debug.cc#n...
> test/cctest/test-debug.cc:6675: i::PrintF("%s is missing exception
> predictions.\n", builtins->name(i));
> The output of this is currently:
> 
> ResolvePromise is missing exception predictions.
> PromiseResolve is missing exception predictions.
> PromiseThenFinally is missing exception predictions.
> PromiseCatchFinally is missing exception predictions.
> AsyncFromSyncIteratorPrototypeNext is missing exception predictions.
> AsyncFromSyncIteratorPrototypeThrow is missing exception predictions.
> AsyncFromSyncIteratorPrototypeReturn is missing exception predictions.

thanks yang, will take a look

[jgruber, 2017-03-07 08:36:14]

lgtm