Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: src/builtins/builtins-promise.cc

Issue 2731273002: [debug] add exception predictions to builtins where missing. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/builtins/builtins-promise.cc
diff --git a/src/builtins/builtins-promise.cc b/src/builtins/builtins-promise.cc
index 0d0238d267e48a339b05d68b72461858392c3611..53dc648fb79db922d4d73fa360db8088f22ff58b 100644
--- a/src/builtins/builtins-promise.cc
+++ b/src/builtins/builtins-promise.cc
@@ -746,7 +746,7 @@ void PromiseBuiltinsAssembler::InternalResolvePromise(Node* context,
Goto(&reject);
Bind(&reject);
- // Don't cause a debug event as this case is forwarding a rejection
+ // Don't cause a debug event as this case is forwarding a rejection.
InternalPromiseReject(context, promise, thenable_value, false);
PromiseSetHasHandler(result);
Goto(&out);
@@ -829,7 +829,8 @@ void PromiseBuiltinsAssembler::InternalResolvePromise(Node* context,
// 9.a Return RejectPromise(promise, then.[[Value]]).
Bind(&if_rejectpromise);
{
- InternalPromiseReject(context, promise, var_reason.value(), true);
+ // Don't cause a debug event as this case is forwarding a rejection.
+ InternalPromiseReject(context, promise, var_reason.value(), false);
Yang 2017/03/06 11:45:02 In the test case we break twice, once in the gette
Goto(&out);
}
« no previous file with comments | « src/bootstrapper.cc ('k') | src/isolate.cc » ('j') | test/cctest/test-debug.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698