Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: test/cctest/test-debug.cc

Issue 2731273002: [debug] add exception predictions to builtins where missing. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-debug.cc
diff --git a/test/cctest/test-debug.cc b/test/cctest/test-debug.cc
index 8d06b1b66e3fa4f949ed024a7c52a57a678df4b4..151fe6c01b7a378f900c19dc8853540f8ef7a818 100644
--- a/test/cctest/test-debug.cc
+++ b/test/cctest/test-debug.cc
@@ -6663,3 +6663,17 @@ TEST(DebugCoverage) {
CHECK_EQ(1, function_data.End().GetColumnNumber());
CHECK_EQ(2, function_data.Count());
}
+
+TEST(BuiltinsExceptionPrediction) {
+ i::Builtins* builtins = CcTest::i_isolate()->builtins();
+ bool fail = false;
+ for (int i = 0; i < i::Builtins::builtin_count; i++) {
+ Code* builtin = builtins->builtin(static_cast<i::Builtins::Name>(i));
+ if (i::HandlerTable::cast(builtin->handler_table())->length() > 0 &&
+ !builtin->is_promise_rejection() && !builtin->is_exception_caught()) {
+ fail = true;
+ i::PrintF("%s is missing exception predictions.\n", builtins->name(i));
Yang 2017/03/06 11:45:02 The output of this is currently: ResolvePromise i
+ }
+ }
+ CHECK(!fail);
+}

Powered by Google App Engine
This is Rietveld 408576698