Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 2733783002: [debug] change coverage API to use offset instead of line/column. (Closed)

Created:
3 years, 9 months ago by Yang
Modified:
3 years, 9 months ago
Reviewers:
caseq, pfeldman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[debug] change coverage API to use offset instead of line/column. R=caseq@chromium.org, pfeldman@chromium.org BUG=v8:5808 Review-Url: https://codereview.chromium.org/2733783002 Cr-Commit-Position: refs/heads/master@{#43662} Committed: https://chromium.googlesource.com/v8/v8/+/77165eb4df97a2131349af98bffcb156b3442d42

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -40 lines) Patch
M src/api.cc View 1 2 chunks +3 lines, -15 lines 0 comments Download
M src/d8.cc View 1 2 chunks +7 lines, -3 lines 0 comments Download
M src/debug/debug-interface.h View 1 1 chunk +4 lines, -6 lines 0 comments Download
M src/inspector/js_protocol.json View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/inspector/v8-profiler-agent-impl.cc View 1 chunk +13 lines, -8 lines 0 comments Download
M test/cctest/test-debug.cc View 1 chunk +14 lines, -8 lines 0 comments Download
M test/inspector/cpu-profiler/coverage-expected.txt View 1 18 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
Yang
Please take a look. This changes the inspector protocol for code coverage to use source ...
3 years, 9 months ago (2017-03-06 06:54:15 UTC) #1
Yang
On 2017/03/06 06:54:15, Yang wrote: > Please take a look. This changes the inspector protocol ...
3 years, 9 months ago (2017-03-06 20:56:08 UTC) #2
caseq
lgtm
3 years, 9 months ago (2017-03-07 00:50:23 UTC) #3
pfeldman
protocol lgtm
3 years, 9 months ago (2017-03-07 02:31:30 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733783002/1
3 years, 9 months ago (2017-03-07 05:36:36 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/builds/17982) v8_linux64_avx2_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 9 months ago (2017-03-07 05:57:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2733783002/20001
3 years, 9 months ago (2017-03-08 06:50:49 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 07:23:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/77165eb4df97a2131349af98bffcb156b34...

Powered by Google App Engine
This is Rietveld 408576698