Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2731103002:
cros: Remove CoreOobeHandler::Delegate. (Closed)
|
Created:
3 years, 9 months ago by jdufault Modified:
3 years, 9 months ago Reviewers:
achuithb CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptioncros: Remove CoreOobeHandler::Delegate.
It was only used for communication within the JS layer, and CoreOobeHandler already has access to the only implementer, OobeUI.
BUG=685287
Review-Url: https://codereview.chromium.org/2731103002
Cr-Commit-Position: refs/heads/master@{#455829}
Committed: https://chromium.googlesource.com/chromium/src/+/fbf043b1bde50e64a940da7afcc6ec3a4abb3dbd
Patch Set 1 : Initial upload #
Total comments: 4
Patch Set 2 : Rebase #Patch Set 3 : Address comments #
Dependent Patchsets: Messages
Total messages: 39 (33 generated)
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== cros: Move CoreOobeView::Delegate into BaseScreenDelegate. BUG=685287 ========== to ========== cros: Move CoreOobeHandler::Delegate into BaseScreenDelegate. BUG=685287 ==========
Description was changed from ========== cros: Move CoreOobeHandler::Delegate into BaseScreenDelegate. BUG=685287 ========== to ========== cros: Remove CoreOobeHandler::Delegate. It was only used for communication within the JS layer, and CoreOobeHandler already has access to the only implementer, OobeUI. BUG=685287 ==========
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
jdufault@chromium.org changed reviewers: + achuith@chromium.org
achuith@ PTAL.
On 2017/03/07 19:13:18, jdufault wrote: > achuith@ PTAL. (You can ignore the parent patch set, this is actually an independent change)
lgtm https://codereview.chromium.org/2731103002/diff/80001/chrome/browser/ui/webui... File chrome/browser/ui/webui/chromeos/login/oobe_ui.cc (right): https://codereview.chromium.org/2731103002/diff/80001/chrome/browser/ui/webui... chrome/browser/ui/webui/chromeos/login/oobe_ui.cc:508: void OobeUI::OnCurrentScreenChanged(OobeScreen new_screen) { I assume nothing has changed in this implementation. https://codereview.chromium.org/2731103002/diff/80001/chrome/browser/ui/webui... File chrome/browser/ui/webui/chromeos/login/oobe_ui.h (right): https://codereview.chromium.org/2731103002/diff/80001/chrome/browser/ui/webui... chrome/browser/ui/webui/chromeos/login/oobe_ui.h:131: // Called by CoreOobeHandler when the screen has changed. Not sure we want to be specific about the caller. And perhaps this should be renamed to CurrentScreenChanged. I feel like OnCurrentScreenChanged is a delegate interface style name.
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by jdufault@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2731103002/diff/80001/chrome/browser/ui/webui... File chrome/browser/ui/webui/chromeos/login/oobe_ui.cc (right): https://codereview.chromium.org/2731103002/diff/80001/chrome/browser/ui/webui... chrome/browser/ui/webui/chromeos/login/oobe_ui.cc:508: void OobeUI::OnCurrentScreenChanged(OobeScreen new_screen) { On 2017/03/08 11:32:52, achuithb wrote: > I assume nothing has changed in this implementation. Yep, no changes. https://codereview.chromium.org/2731103002/diff/80001/chrome/browser/ui/webui... File chrome/browser/ui/webui/chromeos/login/oobe_ui.h (right): https://codereview.chromium.org/2731103002/diff/80001/chrome/browser/ui/webui... chrome/browser/ui/webui/chromeos/login/oobe_ui.h:131: // Called by CoreOobeHandler when the screen has changed. On 2017/03/08 11:32:52, achuithb wrote: > Not sure we want to be specific about the caller. > > And perhaps this should be renamed to CurrentScreenChanged. I feel like > OnCurrentScreenChanged is a delegate interface style name. Done.
The CQ bit was checked by jdufault@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from achuith@chromium.org Link to the patchset: https://codereview.chromium.org/2731103002/#ps120001 (title: "Address comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 120001, "attempt_start_ts": 1489087483108310,
"parent_rev": "53707d796144fb0c60f081e4477b31a7adab4e6d", "commit_rev":
"fbf043b1bde50e64a940da7afcc6ec3a4abb3dbd"}
Message was sent while issue was closed.
Description was changed from ========== cros: Remove CoreOobeHandler::Delegate. It was only used for communication within the JS layer, and CoreOobeHandler already has access to the only implementer, OobeUI. BUG=685287 ========== to ========== cros: Remove CoreOobeHandler::Delegate. It was only used for communication within the JS layer, and CoreOobeHandler already has access to the only implementer, OobeUI. BUG=685287 Review-Url: https://codereview.chromium.org/2731103002 Cr-Commit-Position: refs/heads/master@{#455829} Committed: https://chromium.googlesource.com/chromium/src/+/fbf043b1bde50e64a940da7afcc6... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:120001) as https://chromium.googlesource.com/chromium/src/+/fbf043b1bde50e64a940da7afcc6... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
