Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7340)

Unified Diff: chrome/browser/ui/webui/chromeos/login/oobe_ui.cc

Issue 2731103002: cros: Remove CoreOobeHandler::Delegate. (Closed)
Patch Set: Address comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/oobe_ui.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
diff --git a/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc b/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
index 84e4b4f19b08a2c586ee78e4e3272959a4d83213..6402e03fed7fe9755da3bcd53de3eb90db4da926 100644
--- a/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
+++ b/chrome/browser/ui/webui/chromeos/login/oobe_ui.cc
@@ -219,7 +219,6 @@ OobeUI::OobeUI(content::WebUI* web_ui, const GURL& url)
base::MakeUnique<CoreOobeHandler>(this, js_calls_container.get());
core_handler_ = core_handler.get();
AddWebUIHandler(std::move(core_handler));
- core_handler_->SetDelegate(this);
auto network_dropdown_handler = base::MakeUnique<NetworkDropdownHandler>();
network_dropdown_handler_ = network_dropdown_handler.get();
@@ -328,7 +327,6 @@ OobeUI::OobeUI(content::WebUI* web_ui, const GURL& url)
}
OobeUI::~OobeUI() {
- core_handler_->SetDelegate(nullptr);
network_dropdown_handler_->RemoveObserver(GetView<ErrorScreenHandler>());
if (ash_util::IsRunningInMash()) {
// TODO: Ash needs to expose screen dimming api. See
@@ -503,6 +501,31 @@ void OobeUI::InitializeHandlers() {
shutdown_policy_handler_->NotifyDelegateWithShutdownPolicy();
}
+void OobeUI::CurrentScreenChanged(OobeScreen new_screen) {
+ previous_screen_ = current_screen_;
+
+ const bool should_dim =
+ std::find(std::begin(kDimOverlayScreenIds),
+ std::end(kDimOverlayScreenIds),
+ new_screen) != std::end(kDimOverlayScreenIds);
+ if (!ash_util::IsRunningInMash()) {
+ if (!screen_dimmer_) {
+ screen_dimmer_ = base::MakeUnique<ash::ScreenDimmer>(
+ ash::ScreenDimmer::Container::LOCK_SCREEN);
+ }
+ screen_dimmer_->set_at_bottom(true);
+ screen_dimmer_->SetDimming(should_dim);
+ } else {
+ // TODO: Ash needs to expose screen dimming api. See
+ // http://crbug.com/646034.
+ NOTIMPLEMENTED();
+ }
+
+ current_screen_ = new_screen;
+ for (Observer& observer : observer_list_)
+ observer.OnCurrentScreenChanged(current_screen_, new_screen);
+}
+
void OobeUI::OnScreenAssetsLoaded(const std::string& async_assets_load_id) {
DCHECK(!async_assets_load_id.empty());
@@ -557,31 +580,6 @@ void OobeUI::RemoveObserver(Observer* observer) {
observer_list_.RemoveObserver(observer);
}
-void OobeUI::OnCurrentScreenChanged(OobeScreen new_screen) {
- previous_screen_ = current_screen_;
-
- const bool should_dim =
- std::find(std::begin(kDimOverlayScreenIds),
- std::end(kDimOverlayScreenIds),
- new_screen) != std::end(kDimOverlayScreenIds);
- if (!ash_util::IsRunningInMash()) {
- if (!screen_dimmer_) {
- screen_dimmer_ = base::MakeUnique<ash::ScreenDimmer>(
- ash::ScreenDimmer::Container::LOCK_SCREEN);
- }
- screen_dimmer_->set_at_bottom(true);
- screen_dimmer_->SetDimming(should_dim);
- } else {
- // TODO: Ash needs to expose screen dimming api. See
- // http://crbug.com/646034.
- NOTIMPLEMENTED();
- }
-
- current_screen_ = new_screen;
- for (Observer& observer : observer_list_)
- observer.OnCurrentScreenChanged(current_screen_, new_screen);
-}
-
void OobeUI::UpdateLocalizedStringsIfNeeded() {
if (oobe_ui_md_mode_ ==
g_browser_process->local_state()->GetBoolean(prefs::kOobeMdMode)) {
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/oobe_ui.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698