cros: Remove CoreOobeHandler::Delegate.

chrome/browser/ui/webui/chromeos/login/oobe_ui.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_OOBE_UI_H_
 #define CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_OOBE_UI_H_
 
 #include <map>
 #include <memory>
 #include <string>
@@ skipping 49 matching lines @@
 class UserBoardView;
 class UserImageView;
 class UpdateView;
 class WrongHWIDScreenView;
 
 // A custom WebUI that defines datasource for out-of-box-experience (OOBE) UI:
 // - welcome screen (setup language/keyboard/network).
 // - eula screen (CrOS (+ OEM) EULA content/TPM password/crash reporting).
 // - update screen.
 class OobeUI : public content::WebUIController,
-               public CoreOobeHandler::Delegate,
                public ShutdownPolicyHandler::Delegate {
  public:
   // List of known types of OobeUI. Type added as path in chrome://oobe url, for
   // example chrome://oobe/user-adding.
   static const char kOobeDisplay[];
   static const char kLoginDisplay[];
   static const char kLockDisplay[];
   static const char kUserAddingDisplay[];
   static const char kAppLaunchSplashDisplay[];
   static const char kArcKioskSplashDisplay[];
@@ skipping 41 matching lines @@
 
   // ShutdownPolicyHandler::Delegate
   void OnShutdownPolicyChanged(bool reboot_on_shutdown) override;
 
   // Collects localized strings from the owned handlers.
   void GetLocalizedStrings(base::DictionaryValue* localized_strings);
 
   // Initializes the handlers.
   void InitializeHandlers();
 
+  // Called by CoreOobeHandler when the screen has changed.

[achuithb, 2017/03/08 11:32:52]

Not sure we want to be specific about the caller.

And perhaps this should be renamed to CurrentScreenChanged. I feel like
OnCurrentScreenChanged is a delegate interface style name.

[jdufault, 2017/03/09 19:24:14]

Done.

+  void OnCurrentScreenChanged(OobeScreen screen);
+
   // Invoked after the async assets load. The screen handler that has the same
   // async assets load id will be initialized.
   void OnScreenAssetsLoaded(const std::string& async_assets_load_id);
 
   bool IsJSReady(const base::Closure& display_is_ready_callback);
 
   // Shows or hides OOBE UI elements.
   void ShowOobeUI(bool show);
 
   // Shows the signin screen.
@@ skipping 37 matching lines @@
     }
 
     NOTREACHED() << "Unable to find handler for screen "
                  << GetOobeScreenName(expected_screen);
     return nullptr;
   }
 
   void AddWebUIHandler(std::unique_ptr<BaseWebUIHandler> handler);
   void AddScreenHandler(std::unique_ptr<BaseScreenHandler> handler);
 
-  // CoreOobeHandler::Delegate implementation:
-  void OnCurrentScreenChanged(OobeScreen screen) override;
-
   // Type of UI.
   std::string display_type_;
 
   // Reference to NetworkStateInformer that handles changes in network
   // state.
   scoped_refptr<NetworkStateInformer> network_state_informer_;
 
   // Reference to CoreOobeHandler that handles common requests of Oobe page.
   CoreOobeHandler* core_handler_ = nullptr;
 
@@ skipping 43 matching lines @@
   // Store the deferred JS calls before the screen handler instance is
   // initialized.
   std::unique_ptr<JSCallsContainer> js_calls_container;
 
   DISALLOW_COPY_AND_ASSIGN(OobeUI);
 };
 
 }  // namespace chromeos
 
 #endif  // CHROME_BROWSER_UI_WEBUI_CHROMEOS_LOGIN_OOBE_UI_H_