Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2730903006:
Add new sad tab strings. (Closed)
|
Created:
3 years, 9 months ago by Will Harris Modified:
3 years, 9 months ago CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd new sad tab strings.
These are being added before branch point so they can be localized.
Code will follow.
BUG=697259
Review-Url: https://codereview.chromium.org/2730903006
Cr-Original-Commit-Position: refs/heads/master@{#454667}
Committed: https://chromium.googlesource.com/chromium/src/+/a8206e24e0758e349d1708fab7aa2774980dc4eb
Review-Url: https://codereview.chromium.org/2730903006
Cr-Commit-Position: refs/heads/master@{#454698}
Committed: https://chromium.googlesource.com/chromium/src/+/16fe9a094fcfeacefe25e768918379cc2419d715
Patch Set 1 #
Total comments: 4
Patch Set 2 : code review comments #
Total comments: 46
Patch Set 3 : code review changes II #Patch Set 4 : fix typos #Patch Set 5 : Fix ChromeOS build #Messages
Total messages: 50 (24 generated)
Description was changed from ========== Add new sad tab strings. These are being added before branch point so they can be localized. Code will follow. BUG=697259 ========== to ========== Add new sad tab strings. These are being added before branch point so they can be localized. Code will follow. BUG=697259 ==========
wfh@chromium.org changed reviewers: + sdefresne@chromium.org
PTAL - the bug linked has all the UI approved mocks and strings.
wfh@chromium.org changed reviewers: + yyushkina@google.com
yyushkina please look over these strings and make sure they match the mocks. I coalesced a few platform specific strings into the same ID so it might not match 1:1 your sheet.
wfh@chromium.org changed reviewers: + msw@chromium.org
msw - perhaps you can look over this today as sdefresne is on GMT+2 - we'd like to get these into M58 if possible...
lgtm (since I'm currently in MTV)
yyushkina@chromium.org changed reviewers: + yyushkina@chromium.org
wfh - added two corrections - one to a string, one to a desc https://codereview.chromium.org/2730903006/diff/1/components/new_or_sad_tab_s... File components/new_or_sad_tab_strings.grdp (right): https://codereview.chromium.org/2730903006/diff/1/components/new_or_sad_tab_s... components/new_or_sad_tab_strings.grdp:47: <message name="IDS_SAD_TAB_OOM_MESSAGE_TABS" desc="The title of the sad tab page displayed if a reload failed to fix the issue." formatter_data="android_java"> The desc is off here I believe. It should be "The message displayed on the sad tab page if the tab died due to being out of memory, a reload failed to fix the issue and other tabs are open." https://codereview.chromium.org/2730903006/diff/1/components/new_or_sad_tab_s... components/new_or_sad_tab_strings.grdp:88: Close other tabs or programs This should be "Close other tabs" I believe.
https://codereview.chromium.org/2730903006/diff/1/components/new_or_sad_tab_s... File components/new_or_sad_tab_strings.grdp (right): https://codereview.chromium.org/2730903006/diff/1/components/new_or_sad_tab_s... components/new_or_sad_tab_strings.grdp:47: <message name="IDS_SAD_TAB_OOM_MESSAGE_TABS" desc="The title of the sad tab page displayed if a reload failed to fix the issue." formatter_data="android_java"> On 2017/03/03 18:32:21, yyushkina wrote: > The desc is off here I believe. It should be "The message displayed on the sad > tab page if the tab died due to being out of memory, a reload failed to fix the > issue and other tabs are open." Done. https://codereview.chromium.org/2730903006/diff/1/components/new_or_sad_tab_s... components/new_or_sad_tab_strings.grdp:88: Close other tabs or programs On 2017/03/03 18:32:21, yyushkina wrote: > This should be "Close other tabs" I believe. actually I think "Close other programs" cell B13 on sheet.
yyushkina -> new version is up PTAL.
wfh@chromium.org changed reviewers: - msw@chromium.org, yyushkina@google.com
srahim@google.com changed reviewers: + srahim@google.com
https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... File components/new_or_sad_tab_strings.grdp (right): https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:40: <message name="IDS_SAD_TAB_OOM_TITLE" desc="The title of the sad tab page displayed if the tab died due to being out of memory and a reload failed to fix the issue."> desc="The title of the web page displayed if content in Chrome browser does not load due to the browser being out of memory, and a reload failed to fix the issue." https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:44: <message name="IDS_SAD_TAB_RELOAD_TITLE" desc="The title of the sad tab page displayed if a reload failed to fix the issue."> desc="The title of the web page displayed if content in Chrome browser does not load for an unknown reason, and a reload failed to fix the issue." https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:47: <message name="IDS_SAD_TAB_OOM_MESSAGE_TABS" desc="The message displayed on the sad tab page if the tab died due to being out of memory, a reload failed to fix the issue and other tabs are open." formatter_data="android_java"> desc="The message displayed on the web page if content in Chrome browser does not load due to the browser being out of memory, a reload failed to fix the issue and other tabs are open." https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:50: <message name="IDS_SAD_TAB_OOM_MESSAGE_NOTABS" desc="The message displayed on the sad tab page if the tab died due to being out of memory, a reload failed to fix the issue and no other tabs are open." formatter_data="android_java"> desc="The message displayed on the web page if content in Chrome browser does not load due to the browser being out of memory, a reload failed to fix the issue and no other tabs are open." https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:53: <message name="IDS_SAD_TAB_RELOAD_TRY" desc="The first line of the message displayed on the sad tab page if a reload failed to fix the issue." formatter_data="android_java"> desc="The message displayed on the web page if content in Chrome browser does not load and a reload failed to fix the issue. Introduces a bulleted list of solutions/tips for the user to try." https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:57: <message name="IDS_SAD_TAB_RELOAD_INCOGNITO" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, explaining to try using an incognito tab." formatter_data="android_java"> desc="One of the bullet points displayed on the web page if a reload failed to fix the issue, advising the user to open the web page in Chrome's Incognito mode." https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:58: Open page in Incognito Mode (⇧⌘N) Please change to "Incognito mode" with lowercase 'm' https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:62: <message name="IDS_SAD_TAB_RELOAD_INCOGNITO" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, explaining to try using an incognito tab." formatter_data="android_java"> desc="One of the bullet points displayed on the web page if a reload failed to fix the issue, advising the user to open the web page in Chrome's Incognito mode." https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:63: Open page in Incognito Mode (Ctrl-Shift-N) "Incognito mode" with lowercase m https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:67: <message name="IDS_SAD_TAB_RELOAD_INCOGNITO" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, explaining to try using an incognito tab." formatter_data="android_java"> desc="One of the bullet points displayed on the web page if a reload failed to fix the issue, advising the user to open the web page in Chrome's Incognito mode." https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:68: Open page in Incognito Mode "Incognito mode" with lowercase m https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:72: <message name="IDS_SAD_TAB_RELOAD_CLOSE_TABS" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, and there are other open tabs, explaining to try closing tabs or other programs." formatter_data="android_java"> desc="One of the bullet points displayed on the web page if a reload failed to fix the issue, advising the user to close other Chrome tabs or apps running on their computer (Mac, Chrome OS)." https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:77: <message name="IDS_SAD_TAB_RELOAD_CLOSE_TABS" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, and there are other open tabs, explaining to try closing tabs or other programs." formatter_data="android_java"> desc="One of the bullet points displayed on the web page if a reload failed to fix the issue, advising the user to close other Chrome tabs or programs running on their computer." https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:82: <message name="IDS_SAD_TAB_RELOAD_CLOSE_NOTABS" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, and there are no other open tabs, explaining to try closing other programs." formatter_data="android_java"> desc="One of the bullet points displayed on the web page if a reload failed to fix the issue, advising the user to close other apps running on their computer or device." https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:87: <message name="IDS_SAD_TAB_RELOAD_CLOSE_NOTABS" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, and there are no other open tabs, explaining to try closing other programs." formatter_data="android_java"> desc="One of the bullet points displayed on the web page if a reload failed to fix the issue, advising the user to close other programs running on their computer (Linux)." https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:92: Restart Chrome desc="One of the bullet points displayed on the web page if a reload failed to fix the issue, advising the user to restart the Chrome application." https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:96: Restart your computer desc="One of the bullet points displayed on the web page if a reload failed to fix the issue, advising the user to restart their computer." https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:100: <message name="IDS_SAD_TAB_RELOAD_RESTART_DEVICE" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, explaining to try a restart of device." formatter_data="android_java"> desc="One of the bullet points displayed on the web page if a reload failed to fix the issue, advising the user to restart their device (i.e. phone or tablet)." https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:104: <message name="IDS_SAD_TAB_UMA_OPTIN" desc="Text beside the checkbox to let users opt into UMA." formatter_data="android_java"> desc="Text that appears next to a checkbox, allowing the user to opt-in to sending statistics about their Chrome browser usage and reports of crashes to Google."
https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... File components/new_or_sad_tab_strings.grdp (right): https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:44: <message name="IDS_SAD_TAB_RELOAD_TITLE" desc="The title of the sad tab page displayed if a reload failed to fix the issue."> Does this need formatter_data="android_java"> https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:76: <if expr="is_win or is_linux" Should be just is_linux https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:86: <if expr="is_win or is_linux" Shouldn't this be only is_linux?
https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... File components/new_or_sad_tab_strings.grdp (right): https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:86: <if expr="is_win or is_linux" On 2017/03/03 20:03:27, yyushkina wrote: > Shouldn't this be only is_linux? I changed this to win since it seemed if we ever brought this to win the string would be the same, but I can flip it back.
https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... File components/new_or_sad_tab_strings.grdp (right): https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:76: <if expr="is_win or is_linux" On 2017/03/03 20:03:27, yyushkina wrote: > Should be just is_linux Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:86: <if expr="is_win or is_linux" On 2017/03/03 20:05:29, Will Harris wrote: > On 2017/03/03 20:03:27, yyushkina wrote: > > Shouldn't this be only is_linux? > > I changed this to win since it seemed if we ever brought this to win the string > would be the same, but I can flip it back. Ok. That works
all done. PTAL https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... File components/new_or_sad_tab_strings.grdp (right): https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:40: <message name="IDS_SAD_TAB_OOM_TITLE" desc="The title of the sad tab page displayed if the tab died due to being out of memory and a reload failed to fix the issue."> On 2017/03/03 19:42:08, srahim1 wrote: > desc="The title of the web page displayed if content in Chrome browser does not > load due to the browser being out of memory, and a reload failed to fix the > issue." Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:44: <message name="IDS_SAD_TAB_RELOAD_TITLE" desc="The title of the sad tab page displayed if a reload failed to fix the issue."> On 2017/03/03 20:03:26, yyushkina wrote: > Does this need formatter_data="android_java"> Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:44: <message name="IDS_SAD_TAB_RELOAD_TITLE" desc="The title of the sad tab page displayed if a reload failed to fix the issue."> On 2017/03/03 19:42:08, srahim1 wrote: > desc="The title of the web page displayed if content in Chrome browser does not > load for an unknown reason, and a reload failed to fix the issue." Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:47: <message name="IDS_SAD_TAB_OOM_MESSAGE_TABS" desc="The message displayed on the sad tab page if the tab died due to being out of memory, a reload failed to fix the issue and other tabs are open." formatter_data="android_java"> On 2017/03/03 19:42:08, srahim1 wrote: > desc="The message displayed on the web page if content in Chrome browser does > not load due to the browser being out of memory, a reload failed to fix the > issue and other tabs are open." Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:50: <message name="IDS_SAD_TAB_OOM_MESSAGE_NOTABS" desc="The message displayed on the sad tab page if the tab died due to being out of memory, a reload failed to fix the issue and no other tabs are open." formatter_data="android_java"> On 2017/03/03 19:42:08, srahim1 wrote: > desc="The message displayed on the web page if content in Chrome browser does > not load due to the browser being out of memory, a reload failed to fix the > issue and no other tabs are open." Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:57: <message name="IDS_SAD_TAB_RELOAD_INCOGNITO" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, explaining to try using an incognito tab." formatter_data="android_java"> On 2017/03/03 19:42:08, srahim1 wrote: > desc="One of the bullet points displayed on the web page if a reload failed to > fix the issue, advising the user to open the web page in Chrome's Incognito > mode." Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:58: Open page in Incognito Mode (⇧⌘N) On 2017/03/03 19:42:07, srahim1 wrote: > Please change to "Incognito mode" with lowercase 'm' Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:62: <message name="IDS_SAD_TAB_RELOAD_INCOGNITO" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, explaining to try using an incognito tab." formatter_data="android_java"> On 2017/03/03 19:42:08, srahim1 wrote: > desc="One of the bullet points displayed on the web page if a reload failed to > fix the issue, advising the user to open the web page in Chrome's Incognito > mode." Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:63: Open page in Incognito Mode (Ctrl-Shift-N) On 2017/03/03 19:42:07, srahim1 wrote: > "Incognito mode" with lowercase m Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:67: <message name="IDS_SAD_TAB_RELOAD_INCOGNITO" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, explaining to try using an incognito tab." formatter_data="android_java"> On 2017/03/03 19:42:08, srahim1 wrote: > desc="One of the bullet points displayed on the web page if a reload failed to > fix the issue, advising the user to open the web page in Chrome's Incognito > mode." Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:68: Open page in Incognito Mode On 2017/03/03 19:42:08, srahim1 wrote: > "Incognito mode" with lowercase m Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:72: <message name="IDS_SAD_TAB_RELOAD_CLOSE_TABS" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, and there are other open tabs, explaining to try closing tabs or other programs." formatter_data="android_java"> On 2017/03/03 19:42:08, srahim1 wrote: > desc="One of the bullet points displayed on the web page if a reload failed to > fix the issue, advising the user to close other Chrome tabs or apps running on > their computer (Mac, Chrome OS)." Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:76: <if expr="is_win or is_linux" On 2017/03/03 20:03:27, yyushkina wrote: > Should be just is_linux Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:77: <message name="IDS_SAD_TAB_RELOAD_CLOSE_TABS" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, and there are other open tabs, explaining to try closing tabs or other programs." formatter_data="android_java"> On 2017/03/03 19:42:08, srahim1 wrote: > desc="One of the bullet points displayed on the web page if a reload failed to > fix the issue, advising the user to close other Chrome tabs or programs running > on their computer." Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:82: <message name="IDS_SAD_TAB_RELOAD_CLOSE_NOTABS" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, and there are no other open tabs, explaining to try closing other programs." formatter_data="android_java"> On 2017/03/03 19:42:08, srahim1 wrote: > desc="One of the bullet points displayed on the web page if a reload failed to > fix the issue, advising the user to close other apps running on their computer > or device." Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:86: <if expr="is_win or is_linux" On 2017/03/03 20:05:29, Will Harris wrote: > On 2017/03/03 20:03:27, yyushkina wrote: > > Shouldn't this be only is_linux? > > I changed this to win since it seemed if we ever brought this to win the string > would be the same, but I can flip it back. Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:87: <message name="IDS_SAD_TAB_RELOAD_CLOSE_NOTABS" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, and there are no other open tabs, explaining to try closing other programs." formatter_data="android_java"> On 2017/03/03 19:42:08, srahim1 wrote: > desc="One of the bullet points displayed on the web page if a reload failed to > fix the issue, advising the user to close other programs running on their > computer (Linux)." Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:92: Restart Chrome On 2017/03/03 19:42:08, srahim1 wrote: > desc="One of the bullet points displayed on the web page if a reload failed to > fix the issue, advising the user to restart the Chrome application." Done. added Chromium/Chrome variant. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:96: Restart your computer On 2017/03/03 19:42:07, srahim1 wrote: > desc="One of the bullet points displayed on the web page if a reload failed to > fix the issue, advising the user to restart their computer." Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:100: <message name="IDS_SAD_TAB_RELOAD_RESTART_DEVICE" desc="One of the bullet points displayed on the sad tab page if a reload failed to fix the issue, explaining to try a restart of device." formatter_data="android_java"> On 2017/03/03 19:42:08, srahim1 wrote: > desc="One of the bullet points displayed on the web page if a reload failed to > fix the issue, advising the user to restart their device (i.e. phone or > tablet)." Done. https://codereview.chromium.org/2730903006/diff/20001/components/new_or_sad_t... components/new_or_sad_tab_strings.grdp:104: <message name="IDS_SAD_TAB_UMA_OPTIN" desc="Text beside the checkbox to let users opt into UMA." formatter_data="android_java"> On 2017/03/03 19:42:08, srahim1 wrote: > desc="Text that appears next to a checkbox, allowing the user to opt-in to > sending statistics about their Chrome browser usage and reports of crashes to > Google." Done.
lgtm
lgtm
The CQ bit was checked by wfh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sdefresne@chromium.org, yyushkina@chromium.org, srahim@google.com Link to the patchset: https://codereview.chromium.org/2730903006/#ps60001 (title: "fix typos")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488573425911090,
"parent_rev": "c570b631a9db029a57a73d0b4068d2f625795135", "commit_rev":
"a8206e24e0758e349d1708fab7aa2774980dc4eb"}
Message was sent while issue was closed.
Description was changed from ========== Add new sad tab strings. These are being added before branch point so they can be localized. Code will follow. BUG=697259 ========== to ========== Add new sad tab strings. These are being added before branch point so they can be localized. Code will follow. BUG=697259 Review-Url: https://codereview.chromium.org/2730903006 Cr-Commit-Position: refs/heads/master@{#454667} Committed: https://chromium.googlesource.com/chromium/src/+/a8206e24e0758e349d1708fab7aa... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/a8206e24e0758e349d1708fab7aa...
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2727913007/ by fsamuel@chromium.org. The reason for reverting is: Broke Chrome OS build: grit.exception.DuplicateKey: A duplicate key attribute was found.: IDS_SAD_TAB_RELOAD_CLOSE_TABS, IDS_SAD_TAB_RELOAD_CLOSE_NOTABS .
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/2725403002/ by sclittle@chromium.org. The reason for reverting is: Looks like this broke compilation on ChromiumOS builders. I'm reverting this to fix the builders. E.g.: https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C... https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/Linux%20C....
Message was sent while issue was closed.
thanks for reverting this so quickly.
Message was sent while issue was closed.
Description was changed from ========== Add new sad tab strings. These are being added before branch point so they can be localized. Code will follow. BUG=697259 Review-Url: https://codereview.chromium.org/2730903006 Cr-Commit-Position: refs/heads/master@{#454667} Committed: https://chromium.googlesource.com/chromium/src/+/a8206e24e0758e349d1708fab7aa... ========== to ========== Add new sad tab strings. These are being added before branch point so they can be localized. Code will follow. BUG=697259 Review-Url: https://codereview.chromium.org/2730903006 Cr-Commit-Position: refs/heads/master@{#454667} Committed: https://chromium.googlesource.com/chromium/src/+/a8206e24e0758e349d1708fab7aa... ==========
This is fixed in ps5 - sdefresne can you take a quick look, and I can re-land.
lgtm but how was this not caught by the CQ?
On 2017/03/03 22:02:14, sdefresne wrote: > lgtm but how was this not caught by the CQ? analyze.py determined that changing this file did not trigger a rebuild for some reason. That's probably a bug somewhere in the deps file. I have raised https://bugs.chromium.org/p/chromium/issues/detail?id=698387 to track this, and will follow up on there.
The CQ bit was checked by wfh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yyushkina@chromium.org, srahim@google.com Link to the patchset: https://codereview.chromium.org/2730903006/#ps80001 (title: "Fix ChromeOS build")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by wfh@chromium.org
The CQ bit was checked by wfh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
given crbug/639328 I'm forcing a try dryrun with a false change to force a full try run, to avoid any potential waterfall issues.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #6 (id:100001) has been deleted
The CQ bit was checked by wfh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from yyushkina@chromium.org, srahim@google.com Link to the patchset: https://codereview.chromium.org/2730903006/#ps80001 (title: "Fix ChromeOS build")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488581660565130,
"parent_rev": "f5d05cd52b09318150b2c2873477c88df87f24eb", "commit_rev":
"16fe9a094fcfeacefe25e768918379cc2419d715"}
Message was sent while issue was closed.
Description was changed from ========== Add new sad tab strings. These are being added before branch point so they can be localized. Code will follow. BUG=697259 Review-Url: https://codereview.chromium.org/2730903006 Cr-Commit-Position: refs/heads/master@{#454667} Committed: https://chromium.googlesource.com/chromium/src/+/a8206e24e0758e349d1708fab7aa... ========== to ========== Add new sad tab strings. These are being added before branch point so they can be localized. Code will follow. BUG=697259 Review-Url: https://codereview.chromium.org/2730903006 Cr-Original-Commit-Position: refs/heads/master@{#454667} Committed: https://chromium.googlesource.com/chromium/src/+/a8206e24e0758e349d1708fab7aa... Review-Url: https://codereview.chromium.org/2730903006 Cr-Commit-Position: refs/heads/master@{#454698} Committed: https://chromium.googlesource.com/chromium/src/+/16fe9a094fcfeacefe25e7689183... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/16fe9a094fcfeacefe25e7689183... |
