Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(4)

Issue 2727913007: Revert of Add new sad tab strings. (Closed)

Created:
3 years, 1 month ago by Fady Samuel
Modified:
3 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add new sad tab strings. (patchset #4 id:60001 of https://codereview.chromium.org/2730903006/ ) Reason for revert: Broke Chrome OS build: grit.exception.DuplicateKey: A duplicate key attribute was found.: IDS_SAD_TAB_RELOAD_CLOSE_TABS, IDS_SAD_TAB_RELOAD_CLOSE_NOTABS Original issue's description: > Add new sad tab strings. > > These are being added before branch point so they can be localized. > > Code will follow. > > BUG=697259 > > Review-Url: https://codereview.chromium.org/2730903006 > Cr-Commit-Position: refs/heads/master@{#454667} > Committed: https://chromium.googlesource.com/chromium/src/+/a8206e24e0758e349d1708fab7aa2774980dc4eb TBR=sdefresne@chromium.org,yyushkina@chromium.org,srahim@google.com,wfh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=697259 Review-Url: https://codereview.chromium.org/2727913007 Cr-Commit-Position: refs/heads/master@{#454680} Committed: https://chromium.googlesource.com/chromium/src/+/eb817e15a1be327f188132642196a488a22c8a09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -75 lines) Patch
M components/new_or_sad_tab_strings.grdp View 1 chunk +0 lines, -75 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Fady Samuel
Created Revert of Add new sad tab strings.
3 years, 1 month ago (2017-03-03 21:23:22 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727913007/1
3 years, 1 month ago (2017-03-03 21:23:37 UTC) #3
commit-bot: I haz the power
3 years, 1 month ago (2017-03-03 21:26:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/eb817e15a1be327f188132642196...

Powered by Google App Engine
This is Rietveld 408576698