Chromium Code Reviews
DescriptionReland of Unify freetype-android and freetype2 into one checkout (patchset #1 id:1 of https://codereview.chromium.org/2729703002/ )
Reason for revert:
Fix ready and reviewed https://codereview.chromium.org/2728463003
Original issue's description:
> Revert of Unify freetype-android and freetype2 into one checkout (patchset #2 id:20001 of https://codereview.chromium.org/2720823003/ )
>
> Reason for revert:
> This broke component builds on Android.
>
> Original issue's description:
> > Unify freetype-android and freetype2 into one checkout
> >
> > Removing freetype2 for now, later renaming freetype-android to something
> > more generic.
> >
> > Moving freetype-android from source_set to a component target so that
> > it's generally usable in the other configurations. This should not
> > change much on Android where component resolves to static_library.
> >
> > Also, adding myself to freetype-android OWNERS.
> >
> > TBR'ing jochen for the removal, as presubmit requests an OWNER.
> >
> > BUG=697015
> > TBR=jochen
> >
> > Review-Url: https://codereview.chromium.org/2720823003
> > Cr-Commit-Position: refs/heads/master@{#453918}
> > Committed: https://chromium.googlesource.com/chromium/src/+/4db6eb187710a109f98606588f4fa53b501e15ba
>
> TBR=behdad@chromium.org,bungeman@chromium.org,dpranke@chromium.org,eae@chromium.org,jshin@chromium.org,drott@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=697015
>
> Review-Url: https://codereview.chromium.org/2729703002
> Cr-Commit-Position: refs/heads/master@{#454028}
> Committed: https://chromium.googlesource.com/chromium/src/+/1da0b00909796cae61b947e76830fdfa67d6802c
TBR=behdad@chromium.org,bungeman@chromium.org,dpranke@chromium.org,eae@chromium.org,jshin@chromium.org,twellington@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=697015
Review-Url: https://codereview.chromium.org/2730493002
Cr-Commit-Position: refs/heads/master@{#454056}
Committed: https://chromium.googlesource.com/chromium/src/+/6b4e0da088089a5c4346c8e7546f106d4e5cbbbe
Patch Set 1 #
Total comments: 1
Messages
Total messages: 10 (5 generated)
|