Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1384)

Issue 2729703002: Revert of Unify freetype-android and freetype2 into one checkout (Closed)

Created:
3 years, 9 months ago by Theresa
Modified:
3 years, 9 months ago
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, jam, jochen+watch_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Unify freetype-android and freetype2 into one checkout (patchset #2 id:20001 of https://codereview.chromium.org/2720823003/ ) Reason for revert: This broke component builds on Android. Original issue's description: > Unify freetype-android and freetype2 into one checkout > > Removing freetype2 for now, later renaming freetype-android to something > more generic. > > Moving freetype-android from source_set to a component target so that > it's generally usable in the other configurations. This should not > change much on Android where component resolves to static_library. > > Also, adding myself to freetype-android OWNERS. > > TBR'ing jochen for the removal, as presubmit requests an OWNER. > > BUG=697015 > TBR=jochen > > Review-Url: https://codereview.chromium.org/2720823003 > Cr-Commit-Position: refs/heads/master@{#453918} > Committed: https://chromium.googlesource.com/chromium/src/+/4db6eb187710a109f98606588f4fa53b501e15ba TBR=behdad@chromium.org,bungeman@chromium.org,dpranke@chromium.org,eae@chromium.org,jshin@chromium.org,drott@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=697015 Review-Url: https://codereview.chromium.org/2729703002 Cr-Commit-Position: refs/heads/master@{#454028} Committed: https://chromium.googlesource.com/chromium/src/+/1da0b00909796cae61b947e76830fdfa67d6802c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1686 lines, -30 lines) Patch
M DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/emoji-web-font-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/linux/fast/text/emoji-web-font-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/freetype-android/.clang-format View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/freetype-android/BUILD.gn View 4 chunks +8 lines, -23 lines 0 comments Download
M third_party/freetype-android/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/freetype-android/include/freetype-android-config/ftoption.h View 2 chunks +2 lines, -2 lines 0 comments Download
A third_party/freetype2/.clang-format View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/freetype2/BUILD.gn View 1 chunk +75 lines, -0 lines 0 comments Download
A third_party/freetype2/OWNERS View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/freetype2/README.chromium View 1 chunk +53 lines, -0 lines 0 comments Download
A third_party/freetype2/include/freetype-custom-config/ftconfig.h View 1 chunk +504 lines, -0 lines 0 comments Download
A third_party/freetype2/include/freetype-custom-config/ftmodule.h View 1 chunk +38 lines, -0 lines 0 comments Download
A third_party/freetype2/include/freetype-custom-config/ftoption.h View 1 chunk +969 lines, -0 lines 0 comments Download
A third_party/freetype2/patches/freetype2_symbols_visibility.patch View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Theresa
Created Revert of Unify freetype-android and freetype2 into one checkout
3 years, 9 months ago (2017-03-01 21:11:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729703002/1
3 years, 9 months ago (2017-03-01 21:11:37 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/1da0b00909796cae61b947e76830fdfa67d6802c
3 years, 9 months ago (2017-03-01 21:13:25 UTC) #6
drott
:-( Fix was ready https://codereview.chromium.org/2728463003
3 years, 9 months ago (2017-03-01 21:47:59 UTC) #7
Theresa
On 2017/03/01 21:47:59, drott wrote: > :-( Fix was ready https://codereview.chromium.org/2728463003 My apologies. I didn't ...
3 years, 9 months ago (2017-03-01 21:52:07 UTC) #8
drott
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2730493002/ by drott@chromium.org. ...
3 years, 9 months ago (2017-03-01 21:59:36 UTC) #9
drott
3 years, 9 months ago (2017-03-01 22:00:09 UTC) #10
Message was sent while issue was closed.
On 2017/03/01 at 21:52:07, twellington wrote:
> On 2017/03/01 21:47:59, drott wrote:
> > :-( Fix was ready https://codereview.chromium.org/2728463003
> 
> My apologies. I didn't see the new comments on the original bug. Feel free to
revert the revert and send the fix through the CQ.

No worries. Yes, thanks, I'll do that.

Powered by Google App Engine
This is Rietveld 408576698