Unify freetype-android and freetype2 into one checkout

Unify freetype-android and freetype2 into one checkout

Removing freetype2 for now, later renaming freetype-android to something
more generic.

Moving freetype-android from source_set to a component target so that
it's generally usable in the other configurations. This should not
change much on Android where component resolves to static_library.

Also, adding myself to freetype-android OWNERS.

TBR'ing jochen for the removal, as presubmit requests an OWNER.

BUG=697015
TBR=jochen

Review-Url: https://codereview.chromium.org/2720823003
Cr-Commit-Position: refs/heads/master@{#453918}
Committed: https://chromium.googlesource.com/chromium/src/+/4db6eb187710a109f98606588f4fa53b501e15ba

[drott, 2017-02-28 13:31:02]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 13:31:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[drott, 2017-02-28 14:35:41]

Description was changed from

==========
Unify freetype-android and freetype2 into one checkout

Removing freetype2 for now, later renaming freetype-android to something
more generic.

Moving freetype-android from source_set to a component target so that
it's generally usable in the other configurations. This should not
change much on Android where component resolves to static_library.

BUG=697015
==========

to

==========
Unify freetype-android and freetype2 into one checkout

Removing freetype2 for now, later renaming freetype-android to something
more generic.

Moving freetype-android from source_set to a component target so that
it's generally usable in the other configurations. This should not
change much on Android where component resolves to static_library.

Also, adding myself to freetype-android OWNERS.

BUG=697015
==========

[drott, 2017-02-28 14:49:26]

drott@chromium.org changed reviewers:
+ behdad@chromium.org, bungeman@chromium.org, dpranke@chromium.org,
eae@chromium.org

[drott, 2017-02-28 14:49:54]

drott@chromium.org changed reviewers:
+ jshin@chromium.org

[commit-bot: I haz the power, 2017-02-28 15:17:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 15:17:54]

Dry run: This issue passed the CQ dry run.

[behdad, 2017-02-28 17:44:50]

lgtm

[Dirk Pranke, 2017-02-28 21:09:17]

lgtm. Can we rename `freetype-android` to just `freetype` (doesn't have to be in
this CL, of course ...).

[bungeman-chromium, 2017-03-01 00:28:09]

lgtm with one nit

https://codereview.chromium.org/2720823003/diff/1/third_party/freetype-androi...
File third_party/freetype-android/BUILD.gn (right):

https://codereview.chromium.org/2720823003/diff/1/third_party/freetype-androi...
third_party/freetype-android/BUILD.gn:76: configs += [ ":freetype-visibility" ]
Can this go with the above list? Seems odd to append to the same list twice in a
row.

[drott, 2017-03-01 10:31:06]

The CQ bit was checked by drott@chromium.org

[drott, 2017-03-01 10:31:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, bungeman@chromium.org, behdad@chromium.org
Link to the patchset: https://codereview.chromium.org/2720823003/#ps20001
(title: "Pull visibility config in")

[drott, 2017-03-01 10:31:49]

On 2017/03/01 at 00:28:09, bungeman wrote:
> lgtm with one nit
> 
>
https://codereview.chromium.org/2720823003/diff/1/third_party/freetype-androi...
> File third_party/freetype-android/BUILD.gn (right):
> 
>
https://codereview.chromium.org/2720823003/diff/1/third_party/freetype-androi...
> third_party/freetype-android/BUILD.gn:76: configs += [ ":freetype-visibility"
]
> Can this go with the above list? Seems odd to append to the same list twice in
a row.

Thanks, yes. I had this line under a condition first, then removed the
condition, then it orphaned :-)

[commit-bot: I haz the power, 2017-03-01 10:32:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 10:38:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 10:38:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[drott, 2017-03-01 11:23:13]

On 2017/02/28 at 21:09:17, dpranke wrote:
> lgtm. Can we rename `freetype-android` to just `freetype` (doesn't have to be
in this CL, of course ...).

Yes, sure. I am planning to do that in a later step, as mentioned in the CL
description.

[drott, 2017-03-01 11:27:30]

Description was changed from

==========
Unify freetype-android and freetype2 into one checkout

Removing freetype2 for now, later renaming freetype-android to something
more generic.

Moving freetype-android from source_set to a component target so that
it's generally usable in the other configurations. This should not
change much on Android where component resolves to static_library.

Also, adding myself to freetype-android OWNERS.

BUG=697015
==========

to

==========
Unify freetype-android and freetype2 into one checkout

Removing freetype2 for now, later renaming freetype-android to something
more generic.

Moving freetype-android from source_set to a component target so that
it's generally usable in the other configurations. This should not
change much on Android where component resolves to static_library.

Also, adding myself to freetype-android OWNERS.

TBR'ing jochen for the removal, as presubmit requests an OWNER.

BUG=697015
TBR=jochen
==========

[drott, 2017-03-01 11:27:33]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2017-03-01 11:27:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 12:30:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488367653742540,
"parent_rev": "84b4215d6c4fa677341ba96dfdfa083a27345b74", "commit_rev":
"4db6eb187710a109f98606588f4fa53b501e15ba"}

[commit-bot: I haz the power, 2017-03-01 12:30:49]

Description was changed from

==========
Unify freetype-android and freetype2 into one checkout

Removing freetype2 for now, later renaming freetype-android to something
more generic.

Moving freetype-android from source_set to a component target so that
it's generally usable in the other configurations. This should not
change much on Android where component resolves to static_library.

Also, adding myself to freetype-android OWNERS.

TBR'ing jochen for the removal, as presubmit requests an OWNER.

BUG=697015
TBR=jochen
==========

to

==========
Unify freetype-android and freetype2 into one checkout

Removing freetype2 for now, later renaming freetype-android to something
more generic.

Moving freetype-android from source_set to a component target so that
it's generally usable in the other configurations. This should not
change much on Android where component resolves to static_library.

Also, adding myself to freetype-android OWNERS.

TBR'ing jochen for the removal, as presubmit requests an OWNER.

BUG=697015
TBR=jochen

Review-Url: https://codereview.chromium.org/2720823003
Cr-Commit-Position: refs/heads/master@{#453918}
Committed:
https://chromium.googlesource.com/chromium/src/+/4db6eb187710a109f98606588f4f...
==========

[commit-bot: I haz the power, 2017-03-01 12:30:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4db6eb187710a109f98606588f4f...

[Dirk Pranke, 2017-03-01 16:14:09]

On 2017/03/01 11:23:13, drott wrote:
> On 2017/02/28 at 21:09:17, dpranke wrote:
> > lgtm. Can we rename `freetype-android` to just `freetype` (doesn't have to
be
> in this CL, of course ...).
> 
> Yes, sure. I am planning to do that in a later step, as mentioned in the CL
> description.

Oh, sorry, I missed that :(. Thanks!

[Theresa, 2017-03-01 21:11:00]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2729703002/ by twellington@chromium.org.

The reason for reverting is: This broke component builds on Android..