WebAPKs: Pass callback of type WebApkInstallService::FinishCallback to ShortcutHelper

WebAPKs: Pass callback of type WebApkInstallService::FinishCallback to ShortcutHelper

WebApkInstallService::FinishCallback and WebApkInstaller::FinishCallback have the same
signature. ShortcutHelper calls WebApkInstallService::InstallAsync() and hence
should use the WebApkInstallService::FinishCallback type.

BUG=696132
Review-Url: https://codereview.chromium.org/2727363002
Cr-Original-Commit-Position: refs/heads/master@{#454425}
Review-Url: https://codereview.chromium.org/2729993002
Cr-Commit-Position: refs/heads/master@{#454486}
Committed: https://chromium.googlesource.com/chromium/src/+/fc4948593710fbddb8da850cb9867566a554837a

[pkotwicz, 2017-03-03 01:59:58]

Description was changed from

==========
WebAPKs: Pass callback of type WebApkInstallService::FinishCallback to
ShortcutHelper

WebApkInstallService::FinishCallback and WebApkInstaller::FinishCallback have
the same
signature. ShortcutHelper calls WebApkInstallService::InstallAsync() and henec
should use the WebApkInstallService::FinishCallback type.

BUG=696132

Review-Url: https://codereview.chromium.org/2727363002
Cr-Commit-Position: refs/heads/master@{#454425}
==========

to

==========
WebAPKs: Pass callback of type WebApkInstallService::FinishCallback to
ShortcutHelper

WebApkInstallService::FinishCallback and WebApkInstaller::FinishCallback have
the same
signature. ShortcutHelper calls WebApkInstallService::InstallAsync() and hence
should use the WebApkInstallService::FinishCallback type.

BUG=696132

Review-Url: https://codereview.chromium.org/2727363002
Cr-Commit-Position: refs/heads/master@{#454425}
==========

[pkotwicz, 2017-03-03 02:00:54]

pkotwicz@chromium.org changed reviewers:
+ dominickn@chromium.org

[pkotwicz, 2017-03-03 02:00:55]

Dominick, can you please take a look?

[dominickn, 2017-03-03 02:04:09]

lgtm

https://codereview.chromium.org/2729993002/diff/1/chrome/browser/ui/webui/web...
File chrome/browser/ui/webui/webapks_handler.cc (right):

https://codereview.chromium.org/2729993002/diff/1/chrome/browser/ui/webui/web...
chrome/browser/ui/webui/webapks_handler.cc:8: #include "base/callback_forward.h"
Nit: I don't think callback_forward.h is needed here.

Also, this file isn't really related to the rest of this CL, so maybe separate
it out into another CL?

[dominickn, 2017-03-03 02:04:54]

(That has the added benefit that you can land this straight away)

[pkotwicz, 2017-03-03 02:20:30]

The CQ bit was checked by pkotwicz@chromium.org

[pkotwicz, 2017-03-03 02:20:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org
Link to the patchset: https://codereview.chromium.org/2729993002/#ps60001
(title: "Merge branch 'master' into refactor_shortcut_helper29")

[commit-bot: I haz the power, 2017-03-03 02:21:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 02:58:44]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488507630293340,
"parent_rev": "17e725cb4b30de97279784130bdb36b8a3162a26", "commit_rev":
"fc4948593710fbddb8da850cb9867566a554837a"}

[commit-bot: I haz the power, 2017-03-03 02:59:24]

Description was changed from

==========
WebAPKs: Pass callback of type WebApkInstallService::FinishCallback to
ShortcutHelper

WebApkInstallService::FinishCallback and WebApkInstaller::FinishCallback have
the same
signature. ShortcutHelper calls WebApkInstallService::InstallAsync() and hence
should use the WebApkInstallService::FinishCallback type.

BUG=696132

Review-Url: https://codereview.chromium.org/2727363002
Cr-Commit-Position: refs/heads/master@{#454425}
==========

to

==========
WebAPKs: Pass callback of type WebApkInstallService::FinishCallback to
ShortcutHelper

WebApkInstallService::FinishCallback and WebApkInstaller::FinishCallback have
the same
signature. ShortcutHelper calls WebApkInstallService::InstallAsync() and hence
should use the WebApkInstallService::FinishCallback type.

BUG=696132

Review-Url: https://codereview.chromium.org/2727363002
Cr-Original-Commit-Position: refs/heads/master@{#454425}
Review-Url: https://codereview.chromium.org/2729993002
Cr-Commit-Position: refs/heads/master@{#454486}
Committed:
https://chromium.googlesource.com/chromium/src/+/fc4948593710fbddb8da850cb986...
==========

[commit-bot: I haz the power, 2017-03-03 02:59:25]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fc4948593710fbddb8da850cb986...