Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(549)

Issue 2729993002: WebAPKs: Pass callback of type WebApkInstallService::FinishCallback to ShortcutHelper (Closed)

Created:
3 years, 9 months ago by pkotwicz
Modified:
3 years, 9 months ago
Reviewers:
dominickn
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebAPKs: Pass callback of type WebApkInstallService::FinishCallback to ShortcutHelper WebApkInstallService::FinishCallback and WebApkInstaller::FinishCallback have the same signature. ShortcutHelper calls WebApkInstallService::InstallAsync() and hence should use the WebApkInstallService::FinishCallback type. BUG=696132 Review-Url: https://codereview.chromium.org/2727363002 Cr-Original-Commit-Position: refs/heads/master@{#454425} Review-Url: https://codereview.chromium.org/2729993002 Cr-Commit-Position: refs/heads/master@{#454486} Committed: https://chromium.googlesource.com/chromium/src/+/fc4948593710fbddb8da850cb9867566a554837a

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merge branch 'master' into refactor_shortcut_helper29 #

Patch Set 3 : Merge branch 'master' into refactor_shortcut_helper29 #

Patch Set 4 : Merge branch 'master' into refactor_shortcut_helper29 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/browser/android/banners/app_banner_infobar_delegate_android.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/android/shortcut_helper.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/android/shortcut_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
pkotwicz
Dominick, can you please take a look?
3 years, 9 months ago (2017-03-03 02:00:55 UTC) #3
dominickn
lgtm https://codereview.chromium.org/2729993002/diff/1/chrome/browser/ui/webui/webapks_handler.cc File chrome/browser/ui/webui/webapks_handler.cc (right): https://codereview.chromium.org/2729993002/diff/1/chrome/browser/ui/webui/webapks_handler.cc#newcode8 chrome/browser/ui/webui/webapks_handler.cc:8: #include "base/callback_forward.h" Nit: I don't think callback_forward.h is ...
3 years, 9 months ago (2017-03-03 02:04:09 UTC) #4
dominickn
(That has the added benefit that you can land this straight away)
3 years, 9 months ago (2017-03-03 02:04:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729993002/60001
3 years, 9 months ago (2017-03-03 02:21:14 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 02:59:25 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fc4948593710fbddb8da850cb986...

Powered by Google App Engine
This is Rietveld 408576698