Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 2727363002: Remove unnecessary stuff from SafeBrowsingTest (Closed)

Created:
3 years, 9 months ago by Nate Fischer
Modified:
3 years, 9 months ago
Reviewers:
boliu
CC:
android-webview-reviews_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary stuff from SafeBrowsingTest It's sufficient for this test to use the default waitForCallback(), instead of explicitly specifying a timeout. This cuts down on an import. BUG= Review-Url: https://codereview.chromium.org/2727363002 Cr-Commit-Position: refs/heads/master@{#454425} Committed: https://chromium.googlesource.com/chromium/src/+/fcf6850e3c9e5bb732a6925605d03b5644bd9534

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/SafeBrowsingTest.java View 3 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Nate Fischer
PTAL. We discussed this during the last CL on this file, and I completely forgot ...
3 years, 9 months ago (2017-03-02 23:07:32 UTC) #4
boliu
lgtm
3 years, 9 months ago (2017-03-02 23:09:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727363002/1
3 years, 9 months ago (2017-03-02 23:11:04 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 23:18:26 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fcf6850e3c9e5bb732a6925605d0...

Powered by Google App Engine
This is Rietveld 408576698