Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: chrome/browser/android/shortcut_helper.cc

Issue 2729993002: WebAPKs: Pass callback of type WebApkInstallService::FinishCallback to ShortcutHelper (Closed)
Patch Set: Merge branch 'master' into refactor_shortcut_helper29 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/android/shortcut_helper.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/shortcut_helper.h" 5 #include "chrome/browser/android/shortcut_helper.h"
6 6
7 #include <jni.h> 7 #include <jni.h>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/android/jni_android.h" 10 #include "base/android/jni_android.h"
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 return; 151 return;
152 } 152 }
153 AddShortcutWithSkBitmap(info, webapp_id, icon_bitmap); 153 AddShortcutWithSkBitmap(info, webapp_id, icon_bitmap);
154 } 154 }
155 155
156 // static 156 // static
157 void ShortcutHelper::InstallWebApkWithSkBitmap( 157 void ShortcutHelper::InstallWebApkWithSkBitmap(
158 content::WebContents* web_contents, 158 content::WebContents* web_contents,
159 const ShortcutInfo& info, 159 const ShortcutInfo& info,
160 const SkBitmap& icon_bitmap, 160 const SkBitmap& icon_bitmap,
161 const WebApkInstaller::FinishCallback& callback) { 161 const WebApkInstallService::FinishCallback& callback) {
162 WebApkInstallService::Get(web_contents->GetBrowserContext()) 162 WebApkInstallService::Get(web_contents->GetBrowserContext())
163 ->InstallAsync(info, icon_bitmap, callback); 163 ->InstallAsync(info, icon_bitmap, callback);
164 // Don't record metric for users who install WebAPKs via "unsigned sources" 164 // Don't record metric for users who install WebAPKs via "unsigned sources"
165 // flow. 165 // flow.
166 if (ChromeWebApkHost::GetGooglePlayInstallState() == 166 if (ChromeWebApkHost::GetGooglePlayInstallState() ==
167 GooglePlayInstallState::SUPPORTED) { 167 GooglePlayInstallState::SUPPORTED) {
168 webapk::TrackGooglePlayInstallState(GooglePlayInstallState::SUPPORTED); 168 webapk::TrackGooglePlayInstallState(GooglePlayInstallState::SUPPORTED);
169 } 169 }
170 } 170 }
171 171
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
369 369
370 ShortcutHelper::WebApkInfoCallback* webapk_list_callback = 370 ShortcutHelper::WebApkInfoCallback* webapk_list_callback =
371 reinterpret_cast<ShortcutHelper::WebApkInfoCallback*>(jcallback_pointer); 371 reinterpret_cast<ShortcutHelper::WebApkInfoCallback*>(jcallback_pointer);
372 webapk_list_callback->Run(webapk_list); 372 webapk_list_callback->Run(webapk_list);
373 delete webapk_list_callback; 373 delete webapk_list_callback;
374 } 374 }
375 375
376 bool ShortcutHelper::RegisterShortcutHelper(JNIEnv* env) { 376 bool ShortcutHelper::RegisterShortcutHelper(JNIEnv* env) {
377 return RegisterNativesImpl(env); 377 return RegisterNativesImpl(env);
378 } 378 }
OLDNEW
« no previous file with comments | « chrome/browser/android/shortcut_helper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698