Make "Learn more" button bigger in the Page Info View.

Make "Learn more" button bigger in the Page Info View.

According to https://developer.apple.com/ios/human-interface-guidelines/visual-design/layout/,
minimal size should be 44x44. Today, height is 14.5, making it hard to tap it.

BUG=697508
Review-Url: https://codereview.chromium.org/2729833002
Cr-Commit-Position: refs/heads/master@{#454549}
Committed: https://chromium.googlesource.com/chromium/src/+/5992cf13afe61e422c8fcff55349f2ad778841e9

[Olivier, 2017-03-02 08:40:25]

olivierrobin@chromium.org changed reviewers:
+ rohitrao@chromium.org

[pkl (ping after 24h if needed), 2017-03-02 14:34:21]

pkl@chromium.org changed reviewers:
+ pkl@chromium.org

[pkl (ping after 24h if needed), 2017-03-02 14:34:22]

Just drive-by.

Also, s/Pade Info/Page Info/

https://codereview.chromium.org/2729833002/diff/1/ios/chrome/browser/ui/omnib...
File ios/chrome/browser/ui/omnibox/page_info_view_controller.mm (right):

https://codereview.chromium.org/2729833002/diff/1/ios/chrome/browser/ui/omnib...
ios/chrome/browser/ui/omnibox/page_info_view_controller.mm:513:
frame.size.height = MAX(44, frame.size.height);
Do we normally prefer std::max over MAX ?

[Olivier, 2017-03-02 14:38:24]

Description was changed from

==========
Make "Learn more" button bigger in the Pade Info View.

According to
https://developer.apple.com/ios/human-interface-guidelines/visual-design/layout/,
minimal size should be 44x44. Today, height is 14.5, making it hard to tap it.

BUG=697508
==========

to

==========
Make "Learn more" button bigger in the Page Info View.

According to
https://developer.apple.com/ios/human-interface-guidelines/visual-design/layout/,
minimal size should be 44x44. Today, height is 14.5, making it hard to tap it.

BUG=697508
==========

[rohitrao (ping after 24h), 2017-03-02 18:22:39]

lgtm

Could you add an "after" screenshot to the bug please?

[Olivier, 2017-03-03 08:27:38]

I will add screenshots. Thanks

https://codereview.chromium.org/2729833002/diff/1/ios/chrome/browser/ui/omnib...
File ios/chrome/browser/ui/omnibox/page_info_view_controller.mm (right):

https://codereview.chromium.org/2729833002/diff/1/ios/chrome/browser/ui/omnib...
ios/chrome/browser/ui/omnibox/page_info_view_controller.mm:513:
frame.size.height = MAX(44, frame.size.height);
On 2017/03/02 14:34:22, pklpkl wrote:
> Do we normally prefer std::max over MAX ?

$ find . -name "*.mm" -exec grep "std::max(" {} \; | wc -l
     147

$ find . -name "*.mm" -exec grep "MAX(" {} \; | wc -l
      53

std::max it is

[Olivier, 2017-03-03 08:42:50]

The CQ bit was checked by olivierrobin@chromium.org

[Olivier, 2017-03-03 08:42:50]

The patchset sent to the CQ was uploaded after l-g-t-m from
rohitrao@chromium.org
Link to the patchset: https://codereview.chromium.org/2729833002/#ps20001
(title: "feedback")

[commit-bot: I haz the power, 2017-03-03 08:42:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 09:14:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488530570180860,
"parent_rev": "60eb97fc48ad3a8df63c8b17aacb30985af52dd1", "commit_rev":
"5992cf13afe61e422c8fcff55349f2ad778841e9"}

[commit-bot: I haz the power, 2017-03-03 09:15:30]

Description was changed from

==========
Make "Learn more" button bigger in the Page Info View.

According to
https://developer.apple.com/ios/human-interface-guidelines/visual-design/layout/,
minimal size should be 44x44. Today, height is 14.5, making it hard to tap it.

BUG=697508
==========

to

==========
Make "Learn more" button bigger in the Page Info View.

According to
https://developer.apple.com/ios/human-interface-guidelines/visual-design/layout/,
minimal size should be 44x44. Today, height is 14.5, making it hard to tap it.

BUG=697508

Review-Url: https://codereview.chromium.org/2729833002
Cr-Commit-Position: refs/heads/master@{#454549}
Committed:
https://chromium.googlesource.com/chromium/src/+/5992cf13afe61e422c8fcff55349...
==========

[commit-bot: I haz the power, 2017-03-03 09:15:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5992cf13afe61e422c8fcff55349...