Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: ios/chrome/browser/ui/omnibox/page_info_view_controller.mm

Issue 2729833002: Make "Learn more" button bigger in the Page Info View. (Closed)
Patch Set: feedback Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/omnibox/page_info_view_controller.mm
diff --git a/ios/chrome/browser/ui/omnibox/page_info_view_controller.mm b/ios/chrome/browser/ui/omnibox/page_info_view_controller.mm
index e977b05e787d5a11c536b7c0ffb6325747d7e77e..06fc3330177008c1efd3e5d660fdd6632c17e0c0 100644
--- a/ios/chrome/browser/ui/omnibox/page_info_view_controller.mm
+++ b/ios/chrome/browser/ui/omnibox/page_info_view_controller.mm
@@ -508,6 +508,9 @@ void PageInfoModelBubbleBridge::OnPageInfoModelChanged() {
CGSize sizeWithFont =
[[[button titleLabel] text] cr_pixelAlignedSizeWithFont:font];
frame.size = sizeWithFont;
+ // According to iOS Human Interface Guidelines, minimal size of UIButton
+ // should be 44x44.
+ frame.size.height = std::max<CGFloat>(44, frame.size.height);
[button setFrame:frame];
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698