Make "Learn more" button bigger in the Page Info View.

ios/chrome/browser/ui/omnibox/page_info_view_controller.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/chrome/browser/ui/omnibox/page_info_view_controller.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/mac/bundle_locations.h"
 #import "base/mac/foundation_util.h"
@@ skipping 490 matching lines @@
     return 0;
   }
   // The size of the initial frame is irrelevant since it will be changed based
   // on the size for the string inside.
   CGRect frame = CGRectMake(kButtonXOffset, offset, 100, 10);
 
   UIFont* font = [MDCTypography captionFont];
   CGSize sizeWithFont =
       [[[button titleLabel] text] cr_pixelAlignedSizeWithFont:font];
   frame.size = sizeWithFont;
+  // According to iOS Human Interface Guidelines, minimal size of UIButton
+  // should be 44x44.
+  frame.size.height = MAX(44, frame.size.height);

[pkl (ping after 24h if needed), 2017/03/02 14:34:22]

Do we normally prefer std::max over MAX ?

[Olivier, 2017/03/03 08:27:38]

$ find . -name "*.mm" -exec grep "std::max(" {} \; | wc -l
     147

$ find . -name "*.mm" -exec grep "MAX(" {} \; | wc -l
      53

std::max it is

 
   [button setFrame:frame];
 
   [button.titleLabel setFont:font];
   [button.titleLabel setTextAlignment:NSTextAlignmentLeft];
   [button setTitleColor:PageInfoHelpButtonColor()
                forState:UIControlStateNormal];
   [button setTitleColor:PageInfoHelpButtonColor()
                forState:UIControlStateSelected];
   [button setBackgroundColor:[UIColor clearColor]];
@@ skipping 107 matching lines @@
   [opacityAnimation setFromValue:@1];
   [opacityAnimation setToValue:@0];
   [[containerView_ layer] addAnimation:opacityAnimation forKey:@"animateOut"];
 
   [popupContainer_ setAlpha:0];
   [containerView_ setAlpha:0];
   [CATransaction commit];
 }
 
 @end