Index: remoting/protocol/http_ice_config_request.cc |
diff --git a/remoting/protocol/http_ice_config_request.cc b/remoting/protocol/http_ice_config_request.cc |
index 7364341169190c08b10fbbf17aebb21d3dd8a41f..5993e7469f42bbe0d5a59590aa1e87652e4dfb59 100644 |
--- a/remoting/protocol/http_ice_config_request.cc |
+++ b/remoting/protocol/http_ice_config_request.cc |
@@ -11,6 +11,7 @@ |
#include "base/strings/string_util.h" |
#include "base/values.h" |
#include "net/base/url_util.h" |
+#include "net/traffic_annotation/network_traffic_annotation.h" |
#include "remoting/protocol/ice_config.h" |
namespace remoting { |
@@ -97,8 +98,29 @@ HttpIceConfigRequest::HttpIceConfigRequest( |
UrlRequestFactory* url_request_factory, |
const std::string& url) |
: url_(url) { |
- url_request_ = |
- url_request_factory->CreateUrlRequest(UrlRequest::Type::POST, url_); |
+ net::NetworkTrafficAnnotationTag traffic_annotation = |
+ net::DefineNetworkTrafficAnnotation("...", R"( |
Sergey Ulanov
2017/03/17 18:59:32
"CRD ICE Config Request"
Ramin Halavati
2017/04/03 10:01:25
Done.
|
+ semantics { |
+ sender: "..." |
Sergey Ulanov
2017/03/17 18:59:33
Chrome Remote Desktop
Ramin Halavati
2017/04/03 10:01:25
Done.
|
+ description: "..." |
Sergey Ulanov
2017/03/17 18:59:33
"Request used by Chrome Remote Desktop to fetch IC
Ramin Halavati
2017/04/03 10:01:25
Done.
|
+ trigger: "..." |
Sergey Ulanov
2017/03/17 18:59:32
Chrome Remote Desktop usage.
Ramin Halavati
2017/04/03 10:01:25
Can it be more specific? Like on startup or every
Sergey Ulanov
2017/04/04 00:16:47
When a Chrome Remote Desktop session is being conn
Ramin Halavati
2017/04/04 07:37:18
Done.
|
+ data: "..." |
Sergey Ulanov
2017/03/17 18:59:32
None
Ramin Halavati
2017/04/03 10:01:25
Done.
|
+ destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER |
Sergey Ulanov
2017/03/17 18:59:32
GOOGLE_OWNED_SERVICE
Ramin Halavati
2017/04/03 10:01:25
Done.
|
+ } |
+ policy { |
+ cookies_allowed: false/true |
Sergey Ulanov
2017/03/17 18:59:32
false
Ramin Halavati
2017/04/03 10:01:25
Again, cookies are not specifically disabled. Are
Sergey Ulanov
2017/04/04 00:16:47
They are not needed. Yes, please disable them.
Ramin Halavati
2017/04/04 07:37:18
Done, in https://codereview.chromium.org/279228300
|
+ cookies_store: "..." |
Sergey Ulanov
2017/03/17 18:59:32
N/A
Ramin Halavati
2017/04/03 10:01:25
Acknowledged.
|
+ setting: "..." |
Sergey Ulanov
2017/03/17 18:59:32
Block Chrome Remote Desktop (see https://support.g
Ramin Halavati
2017/04/03 10:01:25
Done.
|
+ chrome_policy { |
+ [POLICY_NAME] { |
Sergey Ulanov
2017/03/17 18:59:32
RemoteAccessHostFirewallTraversal
(only applicable
Ramin Halavati
2017/04/03 10:01:25
Done.
|
+ policy_options {mode: MANDATORY/RECOMMENDED/UNSET} |
Sergey Ulanov
2017/03/17 18:59:32
It's not clear to me what this means.
Ramin Halavati
2017/04/03 10:01:25
Acknowledged.
|
+ [POLICY_NAME]: ... //(value to disable it) |
Sergey Ulanov
2017/03/17 18:59:32
0, false
Ramin Halavati
2017/04/03 10:01:25
Done.
|
+ } |
+ } |
+ policy_exception_justification: "..." |
Sergey Ulanov
2017/03/17 18:59:32
The product is shipped separate from Chrome, excep
Ramin Halavati
2017/04/03 10:01:25
Done.
|
+ })"); |
+ url_request_ = url_request_factory->CreateUrlRequest( |
+ UrlRequest::Type::POST, url_, traffic_annotation); |
url_request_->SetPostData("application/json", ""); |
} |