Network traffic annotation added to chromium_url_request.

remoting/protocol/http_ice_config_request.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/protocol/http_ice_config_request.h"
 
 #include "base/bind.h"
 #include "base/callback_helpers.h"
 #include "base/json/json_reader.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/values.h"
 #include "net/base/url_util.h"
+#include "net/traffic_annotation/network_traffic_annotation.h"
 #include "remoting/protocol/ice_config.h"
 
 namespace remoting {
 namespace protocol {
 
 namespace {
 
 // Ensure ICE config is correct at least one hour after session starts.
 const int kMinimumConfigLifetimeSeconds = 3600;
 
@@ skipping 66 matching lines @@
 
   return true;
 }
 
 }  // namespace
 
 HttpIceConfigRequest::HttpIceConfigRequest(
     UrlRequestFactory* url_request_factory,
     const std::string& url)
     : url_(url) {
-  url_request_ =
-      url_request_factory->CreateUrlRequest(UrlRequest::Type::POST, url_);
+  net::NetworkTrafficAnnotationTag traffic_annotation =
+      net::DefineNetworkTrafficAnnotation("...", R"(

[Sergey Ulanov, 2017/03/17 18:59:32]

"CRD ICE Config Request"

[Ramin Halavati, 2017/04/03 10:01:25]

Done.

+        semantics {
+          sender: "..."

[Sergey Ulanov, 2017/03/17 18:59:33]

Chrome Remote Desktop

[Ramin Halavati, 2017/04/03 10:01:25]

Done.

+          description: "..."

[Sergey Ulanov, 2017/03/17 18:59:33]

"Request used by Chrome Remote Desktop to fetch ICE configuration which contains
list of STUN & TURN servers and TURN credentials"

[Ramin Halavati, 2017/04/03 10:01:25]

Done.

+          trigger: "..."

[Sergey Ulanov, 2017/03/17 18:59:32]

Chrome Remote Desktop usage.

[Ramin Halavati, 2017/04/03 10:01:25]

Can it be more specific? Like on startup or every 10 minutes?

[Sergey Ulanov, 2017/04/04 00:16:47]

When a Chrome Remote Desktop session is being connected and periodically while a
session is active, as necessary.

Currently the API issues credentials that expire every 24 hours, so this request
will only be sent again while session is active more than 24 hours and it needs
to renegotiate the ICE connection (which  is not always the case, e.g. it will
not happen if direct connection is used). The 24 hour period is controlled by
the server and may change.

[Ramin Halavati, 2017/04/04 07:37:18]

Done.

+          data: "..."

[Sergey Ulanov, 2017/03/17 18:59:32]

None

[Ramin Halavati, 2017/04/03 10:01:25]

Done.

+          destination: WEBSITE/GOOGLE_OWNED_SERVICE/OTHER

[Sergey Ulanov, 2017/03/17 18:59:32]

GOOGLE_OWNED_SERVICE

[Ramin Halavati, 2017/04/03 10:01:25]

Done.

+        }
+        policy {
+          cookies_allowed: false/true

[Sergey Ulanov, 2017/03/17 18:59:32]

false

[Ramin Halavati, 2017/04/03 10:01:25]

Again, cookies are not specifically disabled. Are they needed or I can create
another CL that disables them?

[Sergey Ulanov, 2017/04/04 00:16:47]

They are not needed. Yes, please disable them.

[Ramin Halavati, 2017/04/04 07:37:18]

Done, in https://codereview.chromium.org/2792283002

+          cookies_store: "..."

[Sergey Ulanov, 2017/03/17 18:59:32]

N/A

[Ramin Halavati, 2017/04/03 10:01:25]

Acknowledged.

+          setting: "..."

[Sergey Ulanov, 2017/03/17 18:59:32]

Block Chrome Remote Desktop (see
https://support.google.com/chrome/a/answer/2799701?hl=en).

[Ramin Halavati, 2017/04/03 10:01:25]

Done.

+          chrome_policy {
+            [POLICY_NAME] {

[Sergey Ulanov, 2017/03/17 18:59:32]

RemoteAccessHostFirewallTraversal
(only applicable on the host side, doesn't have effect in Android and iOS client
apps).

[Ramin Halavati, 2017/04/03 10:01:25]

Done.

+              policy_options {mode: MANDATORY/RECOMMENDED/UNSET}

[Sergey Ulanov, 2017/03/17 18:59:32]

It's not clear to me what this means.

[Ramin Halavati, 2017/04/03 10:01:25]

Acknowledged.

+              [POLICY_NAME]: ... //(value to disable it)

[Sergey Ulanov, 2017/03/17 18:59:32]

0, false

[Ramin Halavati, 2017/04/03 10:01:25]

Done.

+            }
+          }
+          policy_exception_justification: "..."

[Sergey Ulanov, 2017/03/17 18:59:32]

The product is shipped separate from Chrome, except on Chrome OS.

[Ramin Halavati, 2017/04/03 10:01:25]

Done.

+        })");
+  url_request_ = url_request_factory->CreateUrlRequest(
+      UrlRequest::Type::POST, url_, traffic_annotation);
   url_request_->SetPostData("application/json", "");
 }
 
 HttpIceConfigRequest::~HttpIceConfigRequest() {}
 
 void HttpIceConfigRequest::Send(const OnIceConfigCallback& callback) {
   DCHECK(on_ice_config_callback_.is_null());
   DCHECK(!callback.is_null());
 
   on_ice_config_callback_ = callback;
@@ skipping 90 matching lines @@
   if (errors_found || ice_config.stun_servers.empty() ||
       ice_config.turn_servers.empty()) {
     ice_config.expiration_time = base::Time::Now();
   }
 
   base::ResetAndReturn(&on_ice_config_callback_).Run(ice_config);
 }
 
 }  // namespace protocol
 }  // namespace remoting