Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 2729423003: Network traffic annotation added to chromium_url_request. (Closed)

Created:
3 years, 9 months ago by Ramin Halavati
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Network traffic annotation added to chromium_url_request. Network traffic annotation is added to network request of chromium_url_request. BUG=65660 Review-Url: https://codereview.chromium.org/2729423003 Cr-Commit-Position: refs/heads/master@{#470289} Committed: https://chromium.googlesource.com/chromium/src/+/6826b7bed9c59eb51ba0e7904951f465eafed3f2

Patch Set 1 #

Patch Set 2 : Annotation moved to ChromiumURLRequest constructor. #

Patch Set 3 : Annotation templates added. #

Total comments: 82

Patch Set 4 : Annotations updated. #

Total comments: 2

Patch Set 5 : Annotations updated. #

Patch Set 6 : Support links updated. #

Total comments: 9

Patch Set 7 : Annotation updated. #

Total comments: 1

Patch Set 8 : Annotation updated. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -25 lines) Patch
M remoting/base/chromium_url_request.h View 1 3 chunks +10 lines, -5 lines 0 comments Download
M remoting/base/chromium_url_request.cc View 1 2 3 4 3 chunks +8 lines, -4 lines 0 comments Download
M remoting/base/telemetry_log_writer.cc View 1 2 3 4 5 6 7 2 chunks +26 lines, -2 lines 0 comments Download
M remoting/base/telemetry_log_writer_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M remoting/base/url_request.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M remoting/client/plugin/pepper_url_request.h View 1 3 chunks +7 lines, -3 lines 0 comments Download
M remoting/client/plugin/pepper_url_request.cc View 1 3 chunks +10 lines, -5 lines 0 comments Download
M remoting/protocol/http_ice_config_request.cc View 1 2 3 4 5 6 2 chunks +40 lines, -2 lines 0 comments Download
M remoting/protocol/http_ice_config_request_unittest.cc View 1 2 chunks +3 lines, -1 line 0 comments Download
M remoting/protocol/port_allocator.cc View 1 2 3 4 5 6 2 chunks +36 lines, -1 line 0 comments Download

Messages

Total messages: 39 (13 generated)
Ramin Halavati
We are annotating all network requests in Chromium with a new NetworkTrafficAnnotation scheme. This allows ...
3 years, 9 months ago (2017-03-06 09:06:06 UTC) #2
Sergey Ulanov
ChromiumUrlRequests implements UrlRequest. It's a generic interface used for several different requests, so I'm not ...
3 years, 9 months ago (2017-03-06 19:00:49 UTC) #4
Ramin Halavati
Thank you very much Sergey for the detailed explanation. As this is not part of ...
3 years, 9 months ago (2017-03-07 09:59:24 UTC) #6
Ramin Halavati
On 2017/03/07 09:59:24, Ramin Halavati wrote: > Thank you very much Sergey for the detailed ...
3 years, 9 months ago (2017-03-08 08:14:59 UTC) #7
Sergey Ulanov
On 2017/03/08 08:14:59, Ramin Halavati wrote: > On 2017/03/07 09:59:24, Ramin Halavati wrote: > > ...
3 years, 9 months ago (2017-03-08 18:41:44 UTC) #8
Ramin Halavati
Sergey, As this class is compiled with Chrome and we are adding a presubmit checker ...
3 years, 9 months ago (2017-03-10 09:19:40 UTC) #13
Ramin Halavati
On 2017/03/10 09:19:40, Ramin Halavati wrote: > Sergey, > > As this class is compiled ...
3 years, 9 months ago (2017-03-15 11:58:12 UTC) #14
Sergey Ulanov
https://codereview.chromium.org/2729423003/diff/40001/remoting/base/telemetry_log_writer.cc File remoting/base/telemetry_log_writer.cc (right): https://codereview.chromium.org/2729423003/diff/40001/remoting/base/telemetry_log_writer.cc#newcode73 remoting/base/telemetry_log_writer.cc:73: net::DefineNetworkTrafficAnnotation("...", R"( CRD_telemetry_log or something like that. https://codereview.chromium.org/2729423003/diff/40001/remoting/base/telemetry_log_writer.cc#newcode75 remoting/base/telemetry_log_writer.cc:75: ...
3 years, 9 months ago (2017-03-17 18:59:33 UTC) #15
Ramin Halavati
Hi Sergey, Sorry for long delay, I was OOO until today. Annotations are updated, please ...
3 years, 8 months ago (2017-04-03 10:01:26 UTC) #16
Sergey Ulanov
lgtm https://codereview.chromium.org/2729423003/diff/40001/remoting/base/telemetry_log_writer.cc File remoting/base/telemetry_log_writer.cc (right): https://codereview.chromium.org/2729423003/diff/40001/remoting/base/telemetry_log_writer.cc#newcode82 remoting/base/telemetry_log_writer.cc:82: cookies_allowed: false/true On 2017/04/03 10:01:24, Ramin Halavati wrote: ...
3 years, 8 months ago (2017-04-04 00:16:48 UTC) #17
Ramin Halavati
Sergey: Thank you very much, all comments addressed. I added this CL to disable cookies ...
3 years, 8 months ago (2017-04-04 07:37:18 UTC) #19
jainabhishek
Hello Ramin P-Link for this article is https://support.google.com/chrome/?p=remote_desktop Using these links instead of direct help ...
3 years, 8 months ago (2017-04-04 19:38:49 UTC) #20
Ramin Halavati
Thank you very much Abhishek. Links updated.
3 years, 8 months ago (2017-04-05 07:50:00 UTC) #21
Ramin Halavati
On 2017/04/05 07:50:00, Ramin Halavati wrote: > Thank you very much Abhishek. Links updated. Hi ...
3 years, 8 months ago (2017-04-11 06:08:00 UTC) #22
Sergey Ulanov
On 2017/04/11 06:08:00, Ramin Halavati wrote: > On 2017/04/05 07:50:00, Ramin Halavati wrote: > > ...
3 years, 8 months ago (2017-04-12 22:29:03 UTC) #23
Ramin Halavati
Sergey, Thank you very much, but I am sorry I still have a few ambiguities, ...
3 years, 8 months ago (2017-04-13 06:59:04 UTC) #24
Sergey Ulanov
Sorry I missed your questions last time. https://codereview.chromium.org/2729423003/diff/100001/remoting/base/telemetry_log_writer.cc File remoting/base/telemetry_log_writer.cc (right): https://codereview.chromium.org/2729423003/diff/100001/remoting/base/telemetry_log_writer.cc#newcode77 remoting/base/telemetry_log_writer.cc:77: trigger: "Chrome ...
3 years, 8 months ago (2017-04-18 18:40:52 UTC) #25
Ramin Halavati
Thank you very much. Martin, Any comments? https://codereview.chromium.org/2729423003/diff/100001/remoting/base/telemetry_log_writer.cc File remoting/base/telemetry_log_writer.cc (right): https://codereview.chromium.org/2729423003/diff/100001/remoting/base/telemetry_log_writer.cc#newcode77 remoting/base/telemetry_log_writer.cc:77: trigger: "Chrome ...
3 years, 8 months ago (2017-04-19 05:45:16 UTC) #26
msramek
LGTM with a comment. https://codereview.chromium.org/2729423003/diff/120001/remoting/base/telemetry_log_writer.cc File remoting/base/telemetry_log_writer.cc (right): https://codereview.chromium.org/2729423003/diff/120001/remoting/base/telemetry_log_writer.cc#newcode80 remoting/base/telemetry_log_writer.cc:80: data: "Anonymous usage statistics." This ...
3 years, 8 months ago (2017-04-19 12:07:27 UTC) #27
msramek
LGTM with a comment.
3 years, 8 months ago (2017-04-19 12:07:28 UTC) #28
Ramin Halavati
On 2017/04/19 12:07:28, msramek (recovering) wrote: > LGTM with a comment. Jamie, Since Surgey is ...
3 years, 7 months ago (2017-05-04 07:31:00 UTC) #29
Jamie
On 2017/05/04 07:31:00, Ramin Halavati wrote: > On 2017/04/19 12:07:28, msramek (recovering) wrote: > > ...
3 years, 7 months ago (2017-05-04 16:57:41 UTC) #30
Ramin Halavati
Thank you very much, comment addressed. Martin?
3 years, 7 months ago (2017-05-05 07:19:52 UTC) #31
msramek
LGTM, thanks!
3 years, 7 months ago (2017-05-09 11:20:02 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729423003/160001
3 years, 7 months ago (2017-05-09 11:21:48 UTC) #36
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 12:12:35 UTC) #39
Message was sent while issue was closed.
Committed patchset #8 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/6826b7bed9c59eb51ba0e7904951...

Powered by Google App Engine
This is Rietveld 408576698