Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2792283002: Cookies disabled for ChromiumUrlRequest. (Closed)

Created:
3 years, 8 months ago by Ramin Halavati
Modified:
3 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cookies disabled for ChromiumUrlRequest. Following discussion in https://codereview.chromium.org/2729423003, cookies are disabled for remoting/base/chromium_url_request.cc BUG= Review-Url: https://codereview.chromium.org/2792283002 Cr-Commit-Position: refs/heads/master@{#461797} Committed: https://chromium.googlesource.com/chromium/src/+/f6d347f3fc5dfb79e416719abff15a1d19c81c35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M remoting/base/chromium_url_request.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
Ramin Halavati
Sergey, As discussed before, I disabled the cookies for ChromiumUrlRequest. Please review.
3 years, 8 months ago (2017-04-04 07:37:10 UTC) #6
Sergey Ulanov
lgtm
3 years, 8 months ago (2017-04-04 17:40:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2792283002/1
3 years, 8 months ago (2017-04-04 17:50:17 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-04 19:19:00 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f6d347f3fc5dfb79e416719abff1...

Powered by Google App Engine
This is Rietveld 408576698