Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(961)

Issue 2729093003: Remove some unnecessary 'using namespace' (Closed)

Created:
3 years, 9 months ago by Daniel Bratell
Modified:
3 years, 9 months ago
Reviewers:
fs
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some unnecessary 'using namespace' The construct "using namespace" is not allowed by the Chromium coding style and since these are not even necessary I'm just removing them. Review-Url: https://codereview.chromium.org/2729093003 Cr-Commit-Position: refs/heads/master@{#454605} Committed: https://chromium.googlesource.com/chromium/src/+/2b84baf7219874baadaadee3917f52a1cd4dfee2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M third_party/WebKit/Source/core/css/CSSBasicShapeValues.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/SpaceSplitString.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (8 generated)
Daniel Bratell
3 years, 9 months ago (2017-03-03 15:41:34 UTC) #2
fs
lgtm
3 years, 9 months ago (2017-03-03 15:51:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2729093003/1
3 years, 9 months ago (2017-03-03 17:12:33 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-03-03 17:17:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b84baf7219874baadaadee3917f...

Powered by Google App Engine
This is Rietveld 408576698