Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 2728403003: Stop casting HTMLInputElement to HTMLInputElement. (Closed)

Created:
3 years, 9 months ago by Daniel Bratell
Modified:
3 years, 9 months ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop casting HTMLInputElement to HTMLInputElement. There can be some confusion which cast method to use, the one for HTMLElements or the one for ListedElements so don't even bother. Review-Url: https://codereview.chromium.org/2728403003 Cr-Commit-Position: refs/heads/master@{#454899} Committed: https://chromium.googlesource.com/chromium/src/+/2317b2a9cd96003cbe97d46f5b67758c2fd216da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M third_party/WebKit/Source/core/html/forms/RadioInputType.cpp View 1 chunk +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (4 generated)
Daniel Bratell
Please take a look
3 years, 9 months ago (2017-03-06 16:51:53 UTC) #2
fs
lgtm
3 years, 9 months ago (2017-03-06 17:01:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728403003/1
3 years, 9 months ago (2017-03-06 17:07:17 UTC) #5
commit-bot: I haz the power
3 years, 9 months ago (2017-03-06 18:42:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2317b2a9cd96003cbe97d46f5b67...

Powered by Google App Engine
This is Rietveld 408576698