Add support for MD2, MD4, and MD5 to SignatureAlgorithm.

Add support for MD2, MD4, and MD5 to SignatureAlgorithm.

(At a parsing level it is useful to recognize these for error handling,
even if in practice they aren't used when verifying signatures.)

Review-Url: https://codereview.chromium.org/2728953003
Cr-Commit-Position: refs/heads/master@{#455350}
Committed: https://chromium.googlesource.com/chromium/src/+/37e84a0d658536248f4a4372551c36db2e614c1f

[eroman, 2017-03-03 00:21:12]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 00:21:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-03-03 00:29:43]

eroman@chromium.org changed reviewers:
+ rsleevi@chromium.org

[commit-bot: I haz the power, 2017-03-03 01:04:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 01:04:52]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[eroman, 2017-03-07 20:21:23]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 20:22:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-03-07 20:22:18]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org
- rsleevi@chromium.org

[eroman, 2017-03-07 20:22:18]

Changing reviewer rsleevi --> mattm  (who is reviewing the change this depends
on).

[Ryan Sleevi, 2017-03-07 20:26:34]

rsleevi@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2017-03-07 20:26:35]

LGTM % documentation update

https://codereview.chromium.org/2728953003/diff/20001/net/cert/internal/signa...
File net/cert/internal/signature_policy.cc (right):

https://codereview.chromium.org/2728953003/diff/20001/net/cert/internal/signa...
net/cert/internal/signature_policy.cc:37: // Don't allow MD2, MD4, or MD5.
Is this comment in the wrong place?

https://codereview.chromium.org/2728953003/diff/20001/net/cert/internal/signa...
net/cert/internal/signature_policy.cc:43: }
It's unclear the purpose of this switch (I suspect to get explicit compiler
errors for new algorithms; if so, spell that out?)

[eroman, 2017-03-07 20:41:06]

https://codereview.chromium.org/2728953003/diff/20001/net/cert/internal/signa...
File net/cert/internal/signature_policy.cc (right):

https://codereview.chromium.org/2728953003/diff/20001/net/cert/internal/signa...
net/cert/internal/signature_policy.cc:43: }
On 2017/03/07 20:26:34, Ryan Sleevi wrote:
> It's unclear the purpose of this switch (I suspect to get explicit compiler
> errors for new algorithms; if so, spell that out?)

Thanks.

I have improved the organization and code duplication.

[eroman, 2017-03-07 22:32:21]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-07 22:34:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 02:01:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 02:01:14]

Dry run: This issue passed the CQ dry run.

[eroman, 2017-03-08 02:14:11]

The CQ bit was checked by eroman@chromium.org

[eroman, 2017-03-08 02:14:11]

The patchset sent to the CQ was uploaded after l-g-t-m from rsleevi@chromium.org
Link to the patchset: https://codereview.chromium.org/2728953003/#ps60001
(title: "wow. dumb")

[commit-bot: I haz the power, 2017-03-08 02:14:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 02:22:28]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488939251414660,
"parent_rev": "ac3c0012ce426716061dc073928f701fd64ff712", "commit_rev":
"37e84a0d658536248f4a4372551c36db2e614c1f"}

[commit-bot: I haz the power, 2017-03-08 02:23:08]

Description was changed from

==========
Add support for MD2, MD4, and MD5 to SignatureAlgorithm.

(At a parsing level it is useful to recognize these for error handling,
even if in practice they aren't used when verifying signatures.)
==========

to

==========
Add support for MD2, MD4, and MD5 to SignatureAlgorithm.

(At a parsing level it is useful to recognize these for error handling,
even if in practice they aren't used when verifying signatures.)

Review-Url: https://codereview.chromium.org/2728953003
Cr-Commit-Position: refs/heads/master@{#455350}
Committed:
https://chromium.googlesource.com/chromium/src/+/37e84a0d658536248f4a4372551c...
==========

[commit-bot: I haz the power, 2017-03-08 02:23:08]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/37e84a0d658536248f4a4372551c...