Add support for MD2, MD4, and MD5 to SignatureAlgorithm.

net/cert/internal/signature_algorithm.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/cert/internal/signature_algorithm.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/memory/ptr_util.h"
 #include "base/numerics/safe_math.h"
 #include "net/der/input.h"
 #include "net/der/parse_values.h"
 #include "net/der/parser.h"
 
 namespace net {
 
 namespace {
 
+// md2WithRSAEncryption
+// In dotted notation: 1.2.840.113549.1.1.2
+const uint8_t kOidMd2WithRsaEncryption[] = {0x2a, 0x86, 0x48, 0x86, 0xf7,
+                                            0x0d, 0x01, 0x01, 0x02};
+
+// md4WithRSAEncryption
+// In dotted notation: 1.2.840.113549.1.1.3
+const uint8_t kOidMd4WithRsaEncryption[] = {0x2a, 0x86, 0x48, 0x86, 0xf7,
+                                            0x0d, 0x01, 0x01, 0x03};
+
+// md5WithRSAEncryption
+// In dotted notation: 1.2.840.113549.1.1.4
+const uint8_t kOidMd5WithRsaEncryption[] = {0x2a, 0x86, 0x48, 0x86, 0xf7,
+                                            0x0d, 0x01, 0x01, 0x04};
+
 // From RFC 5912:
 //
 //     sha1WithRSAEncryption OBJECT IDENTIFIER ::= {
 //      iso(1) member-body(2) us(840) rsadsi(113549) pkcs(1)
 //      pkcs-1(1) 5 }
 //
 // In dotted notation: 1.2.840.113549.1.1.5
 const uint8_t kOidSha1WithRsaEncryption[] =
     {0x2a, 0x86, 0x48, 0x86, 0xf7, 0x0d, 0x01, 0x01, 0x05};
 
@@ skipping 479 matching lines @@
 
   if (oid == der::Input(kOidSha1)) {
     hash = DigestAlgorithm::Sha1;
   } else if (oid == der::Input(kOidSha256)) {
     hash = DigestAlgorithm::Sha256;
   } else if (oid == der::Input(kOidSha384)) {
     hash = DigestAlgorithm::Sha384;
   } else if (oid == der::Input(kOidSha512)) {
     hash = DigestAlgorithm::Sha512;
   } else {
+    // TODO(eroman): Support MD2, MD4, MD5 for completeness?
     // Unsupported digest algorithm.
     return false;
   }
 
   // From RFC 5912: "PARAMS TYPE NULL ARE preferredPresent". Which is to say
   // the can either be absent, or NULL.
   if (!IsEmpty(params) && !IsNull(params))
     return false;
 
   *out = hash;
@@ skipping 44 matching lines @@
 
   if (oid == der::Input(kOidEcdsaWithSha512))
     return ParseEcdsa(DigestAlgorithm::Sha512, params);
 
   if (oid == der::Input(kOidRsaSsaPss))
     return ParseRsaPss(params);
 
   if (oid == der::Input(kOidSha1WithRsaSignature))
     return ParseRsaPkcs1(DigestAlgorithm::Sha1, params);
 
+  if (oid == der::Input(kOidMd2WithRsaEncryption))
+    return ParseRsaPkcs1(DigestAlgorithm::Md2, params);
+
+  if (oid == der::Input(kOidMd4WithRsaEncryption))
+    return ParseRsaPkcs1(DigestAlgorithm::Md4, params);
+
+  if (oid == der::Input(kOidMd5WithRsaEncryption))
+    return ParseRsaPkcs1(DigestAlgorithm::Md5, params);
+
   // TODO(crbug.com/634443): Add an error indicating what the OID
   // was.
 
   return nullptr;  // Unsupported OID.
 }
 
 std::unique_ptr<SignatureAlgorithm> SignatureAlgorithm::CreateRsaPkcs1(
     DigestAlgorithm digest) {
   return base::WrapUnique(
       new SignatureAlgorithm(SignatureAlgorithmId::RsaPkcs1, digest, nullptr));
@@ skipping 20 matching lines @@
   return nullptr;
 }
 
 SignatureAlgorithm::SignatureAlgorithm(
     SignatureAlgorithmId algorithm,
     DigestAlgorithm digest,
     std::unique_ptr<SignatureAlgorithmParameters> params)
     : algorithm_(algorithm), digest_(digest), params_(std::move(params)) {}
 
 }  // namespace net