Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: net/cert/internal/parse_ocsp.cc

Issue 2728953003: Add support for MD2, MD4, and MD5 to SignatureAlgorithm. (Closed)
Patch Set: wow. dumb Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/cert/internal/signature_algorithm.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/parse_ocsp.cc
diff --git a/net/cert/internal/parse_ocsp.cc b/net/cert/internal/parse_ocsp.cc
index 0e13fc3d09a0cdd1d438c6e1132267e1c23ac66e..a44290f25e4e95d1cc2ae61341dbff85a4fb9d8c 100644
--- a/net/cert/internal/parse_ocsp.cc
+++ b/net/cert/internal/parse_ocsp.cc
@@ -458,6 +458,11 @@ bool CheckCertID(const der::Input& id_tlv,
HashValueTag type = HASH_VALUE_SHA1;
switch (id.hash_algorithm) {
+ case DigestAlgorithm::Md2:
+ case DigestAlgorithm::Md4:
+ case DigestAlgorithm::Md5:
+ // Unsupported.
+ return false;
case DigestAlgorithm::Sha1:
type = HASH_VALUE_SHA1;
break;
« no previous file with comments | « no previous file | net/cert/internal/signature_algorithm.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698