Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: third_party/WebKit/LayoutTests/bluetooth/characteristic/getDescriptor/gen-descriptor-garbage-collection-ran-during-success.html

Issue 2728813002: bluetooth: Improve error message for retrieving Descriptors when disconnecting (Closed)
Patch Set: Fix conflict error Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <!-- Generated by //third_party/WebKit/LayoutTests/bluetooth/generate.py --> 1 <!-- Generated by //third_party/WebKit/LayoutTests/bluetooth/generate.py -->
2 <!DOCTYPE html> 2 <!DOCTYPE html>
3 <script src="../../../resources/testharness.js"></script> 3 <script src="../../../resources/testharness.js"></script>
4 <script src="../../../resources/testharnessreport.js"></script> 4 <script src="../../../resources/testharnessreport.js"></script>
5 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script> 5 <script src="../../../resources/bluetooth/bluetooth-helpers.js"></script>
6 <script> 6 <script>
7 'use strict'; 7 'use strict';
8 promise_test(() => { 8 promise_test(() => {
9 let promise; 9 let promise;
10 return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter') 10 return setBluetoothFakeAdapter('DisconnectingHealthThermometerAdapter')
11 .then(() => requestDeviceWithKeyDown({ 11 .then(
12 filters: [{services: ['health_thermometer']}]})) 12 () => requestDeviceWithKeyDown(
13 .then(device => device.gatt.connect()) 13 {filters: [{services: ['health_thermometer']}]}))
14 .then(gattServer => gattServer.getPrimaryService('health_thermometer')) 14 .then(device => device.gatt.connect())
15 .then(service => service.getCharacteristic('measurement_interval')) 15 .then(gattServer => gattServer.getPrimaryService('health_thermometer'))
16 .then(characteristic => { 16 .then(service => service.getCharacteristic('measurement_interval'))
17 promise = assert_promise_rejects_with_message( 17 .then(characteristic => {
18 characteristic.getDescriptor(user_description.name), 18 promise = assert_promise_rejects_with_message(
19 new DOMException( 19 characteristic.getDescriptor(user_description.name),
20 'GATT Server is disconnected. Cannot perform GATT operations. ' + 20 new DOMException(
21 '(Re)connect first with `device.gatt.connect`.', 21 'GATT Server is disconnected. Cannot retrieve descriptors. ' +
22 'NetworkError')); 22 '(Re)connect first with `device.gatt.connect`.',
23 // Disconnect called to clear attributeInstanceMap and allow the 23 'NetworkError'));
24 // object to get garbage collected. 24 // Disconnect called to clear attributeInstanceMap and allow the
25 characteristic.service.device.gatt.disconnect(); 25 // object to get garbage collected.
26 }) 26 characteristic.service.device.gatt.disconnect();
27 .then(runGarbageCollection) 27 })
28 .then(() => promise); 28 .then(runGarbageCollection)
29 .then(() => promise);
29 }, 'Garbage Collection ran during a getDescriptor call that succeeds. ' + 30 }, 'Garbage Collection ran during a getDescriptor call that succeeds. ' +
30 'Should not crash.'); 31 'Should not crash.');
31 32
32 </script> 33 </script>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698