Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp

Issue 2728813002: bluetooth: Improve error message for retrieving Descriptors when disconnecting (Closed)
Patch Set: Fix conflict error Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
index 44d46662c83803a736b5d14599f86a61d7b0317d..03f5795f1b9787bfbee86052f8df002f87cd93b8 100644
--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp
@@ -335,9 +335,8 @@ ScriptPromise BluetoothRemoteGATTCharacteristic::getDescriptorsImpl(
const String& descriptorsUUID) {
if (!getGatt()->connected()) {
return ScriptPromise::rejectWithDOMException(
- scriptState,
- // TODO(crbug.com/684445): Change to DescriptorsRetrieval.
- BluetoothError::createNotConnectedException(BluetoothOperation::GATT));
+ scriptState, BluetoothError::createNotConnectedException(
+ BluetoothOperation::DescriptorsRetrieval));
}
if (!getGatt()->device()->isValidCharacteristic(
@@ -377,9 +376,8 @@ void BluetoothRemoteGATTCharacteristic::GetDescriptorsCallback(
// If the device is disconnected, reject.
if (!m_service->device()->gatt()->RemoveFromActiveAlgorithms(resolver)) {
- // TODO(crbug.com/684445): Change to DescriptorsRetrieval.
- resolver->reject(
- BluetoothError::createNotConnectedException(BluetoothOperation::GATT));
+ resolver->reject(BluetoothError::createNotConnectedException(
+ BluetoothOperation::DescriptorsRetrieval));
return;
}
« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/BluetoothError.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698