Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2728423005: Move FrameHost::m_eventHandlerRegistry to Page (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
slangley, haraken
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move FrameHost::m_eventHandlerRegistry to Page Move the field FrameHost::m_eventHandlerRegistry to Page, and update FrameHost methods to directly call the equivalent Page method. BUG=691794 Review-Url: https://codereview.chromium.org/2728423005 Cr-Commit-Position: refs/heads/master@{#455666} Committed: https://chromium.googlesource.com/chromium/src/+/c88cfa0fce93d1ce6ecc57108a776d356c67c765

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M third_party/WebKit/Source/core/frame/FrameHost.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 4 chunks +2 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/Page.cpp View 1 4 chunks +11 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
sashab
3 years, 9 months ago (2017-03-08 03:41:10 UTC) #3
slangley
lgtm
3 years, 9 months ago (2017-03-08 03:44:04 UTC) #5
sashab
haraken ptal
3 years, 9 months ago (2017-03-08 03:44:28 UTC) #7
haraken
LGTM
3 years, 9 months ago (2017-03-08 06:07:30 UTC) #10
Peter Mayo
Note - the patchset on which this depends has been reverted for a test failure.
3 years, 9 months ago (2017-03-08 16:06:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728423005/20001
3 years, 9 months ago (2017-03-09 00:19:15 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-09 04:33:24 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c88cfa0fce93d1ce6ecc57108a77...

Powered by Google App Engine
This is Rietveld 408576698