Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: third_party/WebKit/Source/core/page/Page.h

Issue 2728423005: Move FrameHost::m_eventHandlerRegistry to Page (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2013 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 class AutoscrollController; 49 class AutoscrollController;
50 class BrowserControls; 50 class BrowserControls;
51 class ChromeClient; 51 class ChromeClient;
52 class ClientRectList; 52 class ClientRectList;
53 class ContextMenuClient; 53 class ContextMenuClient;
54 class ContextMenuController; 54 class ContextMenuController;
55 class Document; 55 class Document;
56 class DragCaret; 56 class DragCaret;
57 class DragController; 57 class DragController;
58 class EditorClient; 58 class EditorClient;
59 class EventHandlerRegistry;
59 class FocusController; 60 class FocusController;
60 class Frame; 61 class Frame;
61 class FrameHost; 62 class FrameHost;
62 struct PageScaleConstraints; 63 struct PageScaleConstraints;
63 class PageScaleConstraintsSet; 64 class PageScaleConstraintsSet;
64 class PluginData; 65 class PluginData;
65 class PointerLockController; 66 class PointerLockController;
66 class ScopedPageSuspender; 67 class ScopedPageSuspender;
67 class ScrollingCoordinator; 68 class ScrollingCoordinator;
68 class Settings; 69 class Settings;
(...skipping 113 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 UseCounter& useCounter() { return m_useCounter; } 183 UseCounter& useCounter() { return m_useCounter; }
183 Deprecation& deprecation() { return m_deprecation; } 184 Deprecation& deprecation() { return m_deprecation; }
184 HostsUsingFeatures& hostsUsingFeatures() { return m_hostsUsingFeatures; } 185 HostsUsingFeatures& hostsUsingFeatures() { return m_hostsUsingFeatures; }
185 186
186 PageScaleConstraintsSet& pageScaleConstraintsSet(); 187 PageScaleConstraintsSet& pageScaleConstraintsSet();
187 const PageScaleConstraintsSet& pageScaleConstraintsSet() const; 188 const PageScaleConstraintsSet& pageScaleConstraintsSet() const;
188 189
189 BrowserControls& browserControls(); 190 BrowserControls& browserControls();
190 const BrowserControls& browserControls() const; 191 const BrowserControls& browserControls() const;
191 192
193 EventHandlerRegistry& eventHandlerRegistry();
194 const EventHandlerRegistry& eventHandlerRegistry() const;
195
192 void setTabKeyCyclesThroughElements(bool b) { 196 void setTabKeyCyclesThroughElements(bool b) {
193 m_tabKeyCyclesThroughElements = b; 197 m_tabKeyCyclesThroughElements = b;
194 } 198 }
195 bool tabKeyCyclesThroughElements() const { 199 bool tabKeyCyclesThroughElements() const {
196 return m_tabKeyCyclesThroughElements; 200 return m_tabKeyCyclesThroughElements;
197 } 201 }
198 202
199 // Suspension is used to implement the "Optionally, pause while waiting for 203 // Suspension is used to implement the "Optionally, pause while waiting for
200 // the user to acknowledge the message" step of simple dialog processing: 204 // the user to acknowledge the message" step of simple dialog processing:
201 // https://html.spec.whatwg.org/multipage/webappapis.html#simple-dialogs 205 // https://html.spec.whatwg.org/multipage/webappapis.html#simple-dialogs
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
268 const Member<AutoscrollController> m_autoscrollController; 272 const Member<AutoscrollController> m_autoscrollController;
269 Member<ChromeClient> m_chromeClient; 273 Member<ChromeClient> m_chromeClient;
270 const Member<DragCaret> m_dragCaret; 274 const Member<DragCaret> m_dragCaret;
271 const Member<DragController> m_dragController; 275 const Member<DragController> m_dragController;
272 const Member<FocusController> m_focusController; 276 const Member<FocusController> m_focusController;
273 const Member<ContextMenuController> m_contextMenuController; 277 const Member<ContextMenuController> m_contextMenuController;
274 const std::unique_ptr<PageScaleConstraintsSet> m_pageScaleConstraintsSet; 278 const std::unique_ptr<PageScaleConstraintsSet> m_pageScaleConstraintsSet;
275 const Member<PointerLockController> m_pointerLockController; 279 const Member<PointerLockController> m_pointerLockController;
276 Member<ScrollingCoordinator> m_scrollingCoordinator; 280 Member<ScrollingCoordinator> m_scrollingCoordinator;
277 const Member<BrowserControls> m_browserControls; 281 const Member<BrowserControls> m_browserControls;
282 const Member<EventHandlerRegistry> m_eventHandlerRegistry;
278 283
279 // Typically, the main frame and Page should both be owned by the embedder, 284 // Typically, the main frame and Page should both be owned by the embedder,
280 // which must call Page::willBeDestroyed() prior to destroying Page. This 285 // which must call Page::willBeDestroyed() prior to destroying Page. This
281 // call detaches the main frame and clears this pointer, thus ensuring that 286 // call detaches the main frame and clears this pointer, thus ensuring that
282 // this field only references a live main frame. 287 // this field only references a live main frame.
283 // 288 //
284 // However, there are several locations (InspectorOverlay, SVGImage, and 289 // However, there are several locations (InspectorOverlay, SVGImage, and
285 // WebPagePopupImpl) which don't hold a reference to the main frame at all 290 // WebPagePopupImpl) which don't hold a reference to the main frame at all
286 // after creating it. These are still safe because they always create a 291 // after creating it. These are still safe because they always create a
287 // Frame with a FrameView. FrameView and Frame hold references to each 292 // Frame with a FrameView. FrameView and Frame hold references to each
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 // Page. 330 // Page.
326 // FIXME: Most of the members of Page should move onto FrameHost. 331 // FIXME: Most of the members of Page should move onto FrameHost.
327 Member<FrameHost> m_frameHost; 332 Member<FrameHost> m_frameHost;
328 }; 333 };
329 334
330 extern template class CORE_EXTERN_TEMPLATE_EXPORT Supplement<Page>; 335 extern template class CORE_EXTERN_TEMPLATE_EXPORT Supplement<Page>;
331 336
332 } // namespace blink 337 } // namespace blink
333 338
334 #endif // Page_h 339 #endif // Page_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameHost.cpp ('k') | third_party/WebKit/Source/core/page/Page.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698