Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Issue 2741633002: Remove FrameHost::eventHandlerRegistry() (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
haraken, joelhockey
CC:
blink-layers+watch_chromium.org, blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, jchaffraix+rendering, kenneth.christiansen, kinuko+watch, leviw+renderwatch, Navid Zolghadr, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FrameHost::eventHandlerRegistry() Remove FrameHost::eventHandlerRegistry(), and redirect all calls to Page::eventHandlerRegistry(). BUG=691794 Review-Url: https://codereview.chromium.org/2741633002 Cr-Commit-Position: refs/heads/master@{#455985} Committed: https://chromium.googlesource.com/chromium/src/+/2480b8fee48d2a70bb1dcc9eb4ff37c6a3f95d57

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -58 lines) Patch
M third_party/WebKit/Source/core/dom/Document.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 4 chunks +10 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.h View 1 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameHost.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/shadow/SliderThumbElement.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/input/TouchEventManager.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/ScrollingCoordinator.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (10 generated)
sashab
3 years, 9 months ago (2017-03-09 02:28:22 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-03-09 08:13:58 UTC) #7
joelhockey
lgtm
3 years, 9 months ago (2017-03-10 00:13:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2741633002/20001
3 years, 9 months ago (2017-03-10 02:07:37 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-10 04:26:18 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2480b8fee48d2a70bb1dcc9eb4ff...

Powered by Google App Engine
This is Rietveld 408576698