Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Issue 2728373004: Remove Float32ImageData and update ImageData for color management (Closed)

Created:
3 years, 9 months ago by zakerinasab
Modified:
3 years, 9 months ago
CC:
ajuma+watch-canvas_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-frames_chromium.org, blink-reviews-html_chromium.org, Rik, chromium-reviews, dglazkov+blink, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Float32ImageData and update ImageData for color management Remove Float32ImageData and update ImageData to match the latest changes in the color managed canvas proposal: github.com/junov/CanvasColorSpace/blob/master/CanvasColorSpaceProposal.md BUG=670712 Review-Url: https://codereview.chromium.org/2728373004 Cr-Commit-Position: refs/heads/master@{#456708} Committed: https://chromium.googlesource.com/chromium/src/+/31afd3a4d2c0763304f080c519776cb37ee743a7

Patch Set 1 #

Patch Set 2 : Fixing interface listings #

Patch Set 3 : Fixing interface listings #

Total comments: 8

Patch Set 4 : Addressing comments #

Patch Set 5 : Fixing interface listings #

Total comments: 2

Patch Set 6 : Addressing comments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+463 lines, -806 lines) Patch
D third_party/WebKit/LayoutTests/fast/canvas/canvas-Float32ImageData-constructor.html View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/canvas-Float32ImageData-workers.html View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/color-space/float32ImageData-colorSpace.html View 1 chunk +0 lines, -27 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace.html View 1 2 3 1 chunk +56 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/resources/canvas-Float32ImageData.js View 1 chunk +0 lines, -121 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/canvas/resources/canvas-Float32ImageData-workers.js View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 2 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 2 chunks +2 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 2 chunks +2 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 2 chunks +2 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 2 chunks +2 lines, -8 lines 0 comments Download
A third_party/WebKit/PerformanceTests/Canvas/getImageDataColorManaged.html View 1 2 3 4 5 1 chunk +93 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/BUILD.gn View 1 2 3 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.h View 3 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmap.cpp View 1 2 3 chunks +0 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/frame/ImageBitmapTest.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/BUILD.gn View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/WebKit/Source/core/html/Float32ImageData.h View 1 chunk +0 lines, -96 lines 0 comments Download
D third_party/WebKit/Source/core/html/Float32ImageData.cpp View 1 chunk +0 lines, -173 lines 0 comments Download
D third_party/WebKit/Source/core/html/Float32ImageData.idl View 1 chunk +0 lines, -22 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageData.h View 1 2 3 5 chunks +44 lines, -46 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageData.cpp View 1 2 3 6 chunks +217 lines, -194 lines 0 comments Download
M third_party/WebKit/Source/core/html/ImageData.idl View 1 2 3 2 chunks +11 lines, -5 lines 1 comment Download
A third_party/WebKit/Source/core/html/ImageDataColorSettings.idl View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.h View 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/canvas/CanvasRenderingContext.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Justin Novosad
https://codereview.chromium.org/2728373004/diff/40001/third_party/WebKit/Source/core/html/ImageData.cpp File third_party/WebKit/Source/core/html/ImageData.cpp (right): https://codereview.chromium.org/2728373004/diff/40001/third_party/WebKit/Source/core/html/ImageData.cpp#newcode387 third_party/WebKit/Source/core/html/ImageData.cpp:387: if (m_colorSettings.storageFormat() == kUint8ClampedArrayStorageFormatName) { This series of if/else ...
3 years, 9 months ago (2017-03-10 20:30:26 UTC) #4
zakerinasab
New patch submitted. https://codereview.chromium.org/2728373004/diff/40001/third_party/WebKit/Source/core/html/ImageData.cpp File third_party/WebKit/Source/core/html/ImageData.cpp (right): https://codereview.chromium.org/2728373004/diff/40001/third_party/WebKit/Source/core/html/ImageData.cpp#newcode387 third_party/WebKit/Source/core/html/ImageData.cpp:387: if (m_colorSettings.storageFormat() == kUint8ClampedArrayStorageFormatName) { On ...
3 years, 9 months ago (2017-03-13 15:43:27 UTC) #5
Justin Novosad
https://codereview.chromium.org/2728373004/diff/80001/third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace-perf.html File third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace-perf.html (right): https://codereview.chromium.org/2728373004/diff/80001/third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace-perf.html#newcode1 third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace-perf.html:1: <!DOCTYPE html> Performance tests like this one belong under ...
3 years, 9 months ago (2017-03-13 18:41:06 UTC) #6
zakerinasab
New patch uploaded. https://codereview.chromium.org/2728373004/diff/80001/third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace-perf.html File third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace-perf.html (right): https://codereview.chromium.org/2728373004/diff/80001/third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace-perf.html#newcode1 third_party/WebKit/LayoutTests/fast/canvas/color-space/imageData-colorSpace-perf.html:1: <!DOCTYPE html> On 2017/03/13 18:41:06, Justin ...
3 years, 9 months ago (2017-03-13 19:33:11 UTC) #8
jochen (gone - plz use gerrit)
as this removes a web-exposed feature it seems, there should be an intent to remove. ...
3 years, 9 months ago (2017-03-13 19:44:09 UTC) #9
Justin Novosad
On 2017/03/13 19:44:09, jochen wrote: > as this removes a web-exposed feature it seems, there ...
3 years, 9 months ago (2017-03-13 19:47:45 UTC) #10
jochen (gone - plz use gerrit)
can you help me understand why virtual/stable/webexposed changes?
3 years, 9 months ago (2017-03-13 19:50:55 UTC) #11
zakerinasab
On 2017/03/13 19:50:55, jochen wrote: > can you help me understand why virtual/stable/webexposed changes? The ...
3 years, 9 months ago (2017-03-13 19:56:59 UTC) #12
Justin Novosad
https://codereview.chromium.org/2728373004/diff/120001/third_party/WebKit/Source/core/html/ImageData.idl File third_party/WebKit/Source/core/html/ImageData.idl (left): https://codereview.chromium.org/2728373004/diff/120001/third_party/WebKit/Source/core/html/ImageData.idl#oldcode48 third_party/WebKit/Source/core/html/ImageData.idl:48: readonly attribute ImageDataColorSpace colorSpace; Whoops, looks like this attribute ...
3 years, 9 months ago (2017-03-13 20:00:52 UTC) #13
jochen (gone - plz use gerrit)
ok, idl files and webexposed changes lgtm
3 years, 9 months ago (2017-03-13 21:53:53 UTC) #14
Justin Novosad
lgtm
3 years, 9 months ago (2017-03-14 13:49:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728373004/120001
3 years, 9 months ago (2017-03-14 14:09:02 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 15:40:44 UTC) #20
Message was sent while issue was closed.
Committed patchset #6 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/31afd3a4d2c0763304f080c51977...

Powered by Google App Engine
This is Rietveld 408576698