Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(867)

Unified Diff: third_party/WebKit/Source/core/frame/ImageBitmap.cpp

Issue 2728373004: Remove Float32ImageData and update ImageData for color management (Closed)
Patch Set: Addressing comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/ImageBitmap.cpp
diff --git a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
index bb8b6be608b0081d7d3efe68a742ad24704ef165..a737bfb6373591a2856217fd6cb61abff903b716 100644
--- a/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
+++ b/third_party/WebKit/Source/core/frame/ImageBitmap.cpp
@@ -4,7 +4,6 @@
#include "core/frame/ImageBitmap.h"
-#include "core/html/Float32ImageData.h"
#include "core/html/HTMLCanvasElement.h"
#include "core/html/HTMLVideoElement.h"
#include "core/html/ImageData.h"
@@ -932,11 +931,6 @@ ImageBitmap::ImageBitmap(ImageData* data,
m_image = StaticBitmapImage::create(std::move(skImage));
}
-// TODO(zakerinasab): Fix the constructor from Float32ImageData.
-ImageBitmap::ImageBitmap(Float32ImageData* data,
- Optional<IntRect> cropRect,
- const ImageBitmapOptions& options) {}
-
ImageBitmap::ImageBitmap(ImageBitmap* bitmap,
Optional<IntRect> cropRect,
const ImageBitmapOptions& options) {
@@ -1021,12 +1015,6 @@ ImageBitmap* ImageBitmap::create(ImageData* data,
return new ImageBitmap(data, cropRect, options);
}
-ImageBitmap* ImageBitmap::create(Float32ImageData* data,
- Optional<IntRect> cropRect,
- const ImageBitmapOptions& options) {
- return new ImageBitmap(data, cropRect, options);
-}
-
ImageBitmap* ImageBitmap::create(ImageBitmap* bitmap,
Optional<IntRect> cropRect,
const ImageBitmapOptions& options) {

Powered by Google App Engine
This is Rietveld 408576698