Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 2728133004: Revert of [DevTools] Move 'this' evaluation from ExecutionContext to autocomplete. (Closed)

Created:
3 years, 9 months ago by dgozman
Modified:
3 years, 9 months ago
Reviewers:
caseq, einbinder
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [DevTools] Move 'this' evaluation from ExecutionContext to autocomplete. (patchset #1 id:1 of https://codereview.chromium.org/2729743002/ ) Reason for revert: Not sure this works in all cases Original issue's description: > [DevTools] Move 'this' evaluation from ExecutionContext to autocomplete. > > It's only used by autocomplete logic. > > BUG=none > > Review-Url: https://codereview.chromium.org/2729743002 > Cr-Commit-Position: refs/heads/master@{#454729} > Committed: https://chromium.googlesource.com/chromium/src/+/7791a3fc003f99454ca8cbdcfbbb8d28a0c6c1af TBR=einbinder@chromium.org,caseq@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Review-Url: https://codereview.chromium.org/2728133004 Cr-Commit-Position: refs/heads/master@{#454746} Committed: https://chromium.googlesource.com/chromium/src/+/f5a29c6561e3820a5e71e03c85eb7597b797bfd7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
dgozman
Created Revert of [DevTools] Move 'this' evaluation from ExecutionContext to autocomplete.
3 years, 9 months ago (2017-03-04 01:57:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2728133004/1
3 years, 9 months ago (2017-03-04 01:57:29 UTC) #3
commit-bot: I haz the power
3 years, 9 months ago (2017-03-04 01:59:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f5a29c6561e3820a5e71e03c85eb...

Powered by Google App Engine
This is Rietveld 408576698