Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(750)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

Issue 2728133004: Revert of [DevTools] Move 'this' evaluation from ExecutionContext to autocomplete. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
index 85a4834693db0d93d77fe9f843133b15c7192d7e..4edc2a27233dcc7c3ba6d8f3f5f5cf75e64db21e 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
@@ -544,6 +544,11 @@
generatePreview,
userGesture,
callback) {
+ if (!expression) {
+ // There is no expression, so the completion should happen against global properties.
+ expression = 'this';
+ }
+
/**
* @this {SDK.ExecutionContext}
* @param {?Protocol.Error} error
« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/object_ui/JavaScriptAutocomplete.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698