[DevTools] Move 'this' evaluation from ExecutionContext to autocomplete.

[DevTools] Move 'this' evaluation from ExecutionContext to autocomplete.

It's only used by autocomplete logic.

BUG=none

Review-Url: https://codereview.chromium.org/2729743002
Cr-Commit-Position: refs/heads/master@{#454729}
Committed: https://chromium.googlesource.com/chromium/src/+/7791a3fc003f99454ca8cbdcfbbb8d28a0c6c1af

[dgozman, 2017-03-02 01:41:35]

dgozman@chromium.org changed reviewers:
+ caseq@chromium.org, einbinder@chromium.org

[dgozman, 2017-03-02 01:41:36]

Take a look please.

[einbinder, 2017-03-02 01:48:56]

lgtm

https://codereview.chromium.org/2729743002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right):

https://codereview.chromium.org/2729743002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:512:
this.debuggerModel.evaluateOnSelectedCallFrame(
Did you test this behavior? Expression will be 'this' here instead of ''.

[dgozman, 2017-03-03 23:27:14]

https://codereview.chromium.org/2729743002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js (right):

https://codereview.chromium.org/2729743002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js:512:
this.debuggerModel.evaluateOnSelectedCallFrame(
On 2017/03/02 01:48:56, einbinder wrote:
> Did you test this behavior? Expression will be 'this' here instead of ''.

Works nicely.

[dgozman, 2017-03-03 23:27:54]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2017-03-03 23:28:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 23:28:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 23:28:06]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[caseq, 2017-03-03 23:32:58]

The CQ bit was checked by caseq@chromium.org

[caseq, 2017-03-03 23:32:59]

lgtm

[commit-bot: I haz the power, 2017-03-03 23:33:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 00:52:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488583978514180, "parent_rev":
"6125ed888b761ec02660821245615da02587008c", "commit_rev":
"7791a3fc003f99454ca8cbdcfbbb8d28a0c6c1af"}

[commit-bot: I haz the power, 2017-03-04 00:53:26]

Description was changed from

==========
[DevTools] Move 'this' evaluation from ExecutionContext to autocomplete.

It's only used by autocomplete logic.

BUG=none
==========

to

==========
[DevTools] Move 'this' evaluation from ExecutionContext to autocomplete.

It's only used by autocomplete logic.

BUG=none

Review-Url: https://codereview.chromium.org/2729743002
Cr-Commit-Position: refs/heads/master@{#454729}
Committed:
https://chromium.googlesource.com/chromium/src/+/7791a3fc003f99454ca8cbdcfbbb...
==========

[commit-bot: I haz the power, 2017-03-04 00:53:27]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7791a3fc003f99454ca8cbdcfbbb...

[dgozman, 2017-03-04 01:57:14]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2728133004/ by dgozman@chromium.org.

The reason for reverting is: Not sure this works in all cases.