bluetooth: Clean up connection errors

bluetooth: Clean up connection error messages

Android documentation is incomplete when it comes to connection error codes,
which led us to believe that all values documented here[1] could be returned
by the platform. We opened http://crbug.com/531058 to include all these values
in our ConnectErrorCode enum.

http://crrev.com/1464443002 was then submitted to include all these values in 
our enum.

Upon further investigation we realized that these values were not being returned
by the platform and needed to be removed from our ConnectErrorCode enum.

This patch reverts the changes in http://crrev.com/1464443002 which means:

1. Removing the values from the enum
2. Changing all clients' switch statements that used the enum
3. Fixing test that used these values
4. Removing strings that described these errors


Also http://crrev.com/1464443002 broke a test this patch also fixes that test.

[1] https://developer.android.com/reference/android/bluetooth/BluetoothGatt.html

BUG=598341, 578191
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2727683003
Cr-Commit-Position: refs/heads/master@{#456617}
Committed: https://chromium.googlesource.com/chromium/src/+/9187d13054b869580045f81d8d55f84c6cf150fa

[ortuno, 2017-03-02 02:01:37]

Description was changed from

==========
bluetooth: Clean up connection error messages

Removes errors that were incorrectly added a while ago and fixes a test
that was disabled.

BUG=598341
==========

to

==========
bluetooth: Clean up connection error messages

Removes errors that were incorrectly added a while ago and fixes a test
that was disabled.

BUG=598341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[ortuno, 2017-03-02 02:01:51]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 02:04:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 02:27:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 02:27:54]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[ortuno, 2017-03-02 03:22:37]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 03:23:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 05:34:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 05:34:48]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[ortuno, 2017-03-02 06:40:51]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 06:41:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 08:27:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 08:27:25]

Dry run: This issue passed the CQ dry run.

[ortuno, 2017-03-02 20:51:06]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2017-03-02 20:51:07]

scheib: PTAL

[scheib, 2017-03-07 06:20:22]

Improve the description some to clarify how these enums are changing a bit --
are they just the ConnectErrorCode values and how they propagate up through the
system? Why also add the new Android codes -- consider splitting that out?


Are the histograms from 
https://bugs.chromium.org/p/chromium/issues/detail?id=578191 being used for the
new android values?

I think https://bugs.chromium.org/p/chromium/issues/detail?id=531058 and
https://codereview.chromium.org/1464443002 should be referenced explicitly for
the incorrect enums.

Add all the relevant BUG #s.

https://codereview.chromium.org/2727683003/diff/60001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
(right):

https://codereview.chromium.org/2727683003/diff/60001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:837:
// errorUUID(alias) returns a UUID with the top 32 bits of
Why are we removing connectErrorUUID? I'll read further and perhaps find out --
but it was a much more stable way of referring to these UUIDs. (Though, I'm
looking forward to programatic tests fixing this and making it obsolete).

https://codereview.chromium.org/2727683003/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device_android.cc (right):

https://codereview.chromium.org/2727683003/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device_android.cc:220: // The following errors are
based on errors seen in the wild.
I'm wondering if this patch has too many changes at once.

https://codereview.chromium.org/2727683003/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2727683003/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:111618: +  <int value="10"
label="(Obsolete) Invalid Attribute Length"/>
Where are these being reported from --- do we need to preserve the old histogram
value mapping? The bluetooth_device.h change doesn't:
https://codereview.chromium.org/2727683003/diff/60001/device/bluetooth/blueto...

[ortuno, 2017-03-08 00:39:58]

Description was changed from

==========
bluetooth: Clean up connection error messages

Removes errors that were incorrectly added a while ago and fixes a test
that was disabled.

BUG=598341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
bluetooth: Clean up connection error messages

Android documentation is incomplete when it comes to connection error codes,
which led us to believe that all values documented here[1] could be returned
by the platform. We opened http://crbug.com/531058 to include all these values
in our ConnectErrorCode enum.

http://crrev.com/1464443002 was then submitted to include all these values in 
our enum.

Upon further investigation we realized that these values were not being returned
by the platform and needed to be removed from our ConnectErrorCode enum.

This patch reverts the changes in http://crrev.com/1464443002 which means:

1. Removing the values from the enum
2. Changing all clients' switch statements that used the enum
3. Fixing test that used these values
4. Removing strings that described these errors

BUG=598341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[ortuno, 2017-03-08 00:40:42]

Description was changed from

==========
bluetooth: Clean up connection error messages

Android documentation is incomplete when it comes to connection error codes,
which led us to believe that all values documented here[1] could be returned
by the platform. We opened http://crbug.com/531058 to include all these values
in our ConnectErrorCode enum.

http://crrev.com/1464443002 was then submitted to include all these values in 
our enum.

Upon further investigation we realized that these values were not being returned
by the platform and needed to be removed from our ConnectErrorCode enum.

This patch reverts the changes in http://crrev.com/1464443002 which means:

1. Removing the values from the enum
2. Changing all clients' switch statements that used the enum
3. Fixing test that used these values
4. Removing strings that described these errors

BUG=598341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
bluetooth: Clean up connection error messages

Android documentation is incomplete when it comes to connection error codes,
which led us to believe that all values documented here[1] could be returned
by the platform. We opened http://crbug.com/531058 to include all these values
in our ConnectErrorCode enum.

http://crrev.com/1464443002 was then submitted to include all these values in 
our enum.

Upon further investigation we realized that these values were not being returned
by the platform and needed to be removed from our ConnectErrorCode enum.

This patch reverts the changes in http://crrev.com/1464443002 which means:

1. Removing the values from the enum
2. Changing all clients' switch statements that used the enum
3. Fixing test that used these values
4. Removing strings that described these errors


[1] https://developer.android.com/reference/android/bluetooth/BluetoothGatt.html

BUG=598341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[ortuno, 2017-03-08 00:43:20]

Description was changed from

==========
bluetooth: Clean up connection error messages

Android documentation is incomplete when it comes to connection error codes,
which led us to believe that all values documented here[1] could be returned
by the platform. We opened http://crbug.com/531058 to include all these values
in our ConnectErrorCode enum.

http://crrev.com/1464443002 was then submitted to include all these values in 
our enum.

Upon further investigation we realized that these values were not being returned
by the platform and needed to be removed from our ConnectErrorCode enum.

This patch reverts the changes in http://crrev.com/1464443002 which means:

1. Removing the values from the enum
2. Changing all clients' switch statements that used the enum
3. Fixing test that used these values
4. Removing strings that described these errors


[1] https://developer.android.com/reference/android/bluetooth/BluetoothGatt.html

BUG=598341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
bluetooth: Clean up connection error messages

Android documentation is incomplete when it comes to connection error codes,
which led us to believe that all values documented here[1] could be returned
by the platform. We opened http://crbug.com/531058 to include all these values
in our ConnectErrorCode enum.

http://crrev.com/1464443002 was then submitted to include all these values in 
our enum.

Upon further investigation we realized that these values were not being returned
by the platform and needed to be removed from our ConnectErrorCode enum.

This patch reverts the changes in http://crrev.com/1464443002 which means:

1. Removing the values from the enum
2. Changing all clients' switch statements that used the enum
3. Fixing test that used these values
4. Removing strings that described these errors


Also http://crrev.com/1464443002 broke a test this patch also fixes that test.

[1] https://developer.android.com/reference/android/bluetooth/BluetoothGatt.html

BUG=598341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[ortuno, 2017-03-08 01:45:19]

Description was changed from

==========
bluetooth: Clean up connection error messages

Android documentation is incomplete when it comes to connection error codes,
which led us to believe that all values documented here[1] could be returned
by the platform. We opened http://crbug.com/531058 to include all these values
in our ConnectErrorCode enum.

http://crrev.com/1464443002 was then submitted to include all these values in 
our enum.

Upon further investigation we realized that these values were not being returned
by the platform and needed to be removed from our ConnectErrorCode enum.

This patch reverts the changes in http://crrev.com/1464443002 which means:

1. Removing the values from the enum
2. Changing all clients' switch statements that used the enum
3. Fixing test that used these values
4. Removing strings that described these errors


Also http://crrev.com/1464443002 broke a test this patch also fixes that test.

[1] https://developer.android.com/reference/android/bluetooth/BluetoothGatt.html

BUG=598341
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
bluetooth: Clean up connection error messages

Android documentation is incomplete when it comes to connection error codes,
which led us to believe that all values documented here[1] could be returned
by the platform. We opened http://crbug.com/531058 to include all these values
in our ConnectErrorCode enum.

http://crrev.com/1464443002 was then submitted to include all these values in 
our enum.

Upon further investigation we realized that these values were not being returned
by the platform and needed to be removed from our ConnectErrorCode enum.

This patch reverts the changes in http://crrev.com/1464443002 which means:

1. Removing the values from the enum
2. Changing all clients' switch statements that used the enum
3. Fixing test that used these values
4. Removing strings that described these errors


Also http://crrev.com/1464443002 broke a test this patch also fixes that test.

[1] https://developer.android.com/reference/android/bluetooth/BluetoothGatt.html

BUG=598341, 578191
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[ortuno, 2017-03-08 01:46:10]

> Improve the description some to clarify how these enums are changing a bit --
are they just the ConnectErrorCode values and how they propagate up through the
system? Why also add the new Android codes -- consider splitting that out?
>
>

Done.

> Are the histograms from 
https://bugs.chromium.org/p/chromium/issues/detail?id=578191 being used for the
new android values?
>

They are. I only saw those two errors when connections fail. There are many more
if a connection breaks.

> I think https://bugs.chromium.org/p/chromium/issues/detail?id=531058 and
https://codereview.chromium.org/1464443002 should be referenced explicitly for
the incorrect enums.
>

Done.

> Add all the relevant BUG #s.

Done

https://codereview.chromium.org/2727683003/diff/60001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
(right):

https://codereview.chromium.org/2727683003/diff/60001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:837:
// errorUUID(alias) returns a UUID with the top 32 bits of
On 2017/03/07 at 06:20:22, scheib wrote:
> Why are we removing connectErrorUUID? I'll read further and perhaps find out
-- but it was a much more stable way of referring to these UUIDs. (Though, I'm
looking forward to programatic tests fixing this and making it obsolete).

There were actually no calls to connectErrorUUID D: so I just removed it. I
could change the fake adapter to use it instead but it seemed unnecessary since
as you said we are moving to programatic tests. I don't feel strongly about this
so happy to change if you think we should use connectErrorUUID.

https://codereview.chromium.org/2727683003/diff/60001/device/bluetooth/blueto...
File device/bluetooth/bluetooth_device_android.cc (right):

https://codereview.chromium.org/2727683003/diff/60001/device/bluetooth/blueto...
device/bluetooth/bluetooth_device_android.cc:220: // The following errors are
based on errors seen in the wild.
On 2017/03/07 at 06:20:22, scheib wrote:
> I'm wondering if this patch has too many changes at once.

I think it does. Removed changes to android.

https://codereview.chromium.org/2727683003/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2727683003/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:111618: +  <int value="10"
label="(Obsolete) Invalid Attribute Length"/>
On 2017/03/07 at 06:20:22, scheib wrote:
> Where are these being reported from --- do we need to preserve the old
histogram value mapping? The bluetooth_device.h change doesn't:
>
https://codereview.chromium.org/2727683003/diff/60001/device/bluetooth/blueto...

These are coming from connectGATT's outcome[1]. We have no instances[2] of any
of these values being reported so I think it's safe to remove them from the enum
and the histogram.

Done.

[1]
https://cs.chromium.org/chromium/src/content/browser/bluetooth/bluetooth_metr...

[2]
https://uma.googleplex.com/p/chrome/timeline_v2/?sid=292d822142f075ead13389b4...

[ortuno, 2017-03-08 01:59:36]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-08 02:00:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2017-03-08 02:36:09]

Thanks!

https://codereview.chromium.org/2727683003/diff/60001/content/shell/browser/l...
File content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h
(right):

https://codereview.chromium.org/2727683003/diff/60001/content/shell/browser/l...
content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h:837:
// errorUUID(alias) returns a UUID with the top 32 bits of
On 2017/03/08 01:46:10, ortuno wrote:
> On 2017/03/07 at 06:20:22, scheib wrote:
> > Why are we removing connectErrorUUID? I'll read further and perhaps find out
> -- but it was a much more stable way of referring to these UUIDs. (Though, I'm
> looking forward to programatic tests fixing this and making it obsolete).
> 
> There were actually no calls to connectErrorUUID D: so I just removed it. I
> could change the fake adapter to use it instead but it seemed unnecessary
since
> as you said we are moving to programatic tests. I don't feel strongly about
this
> so happy to change if you think we should use connectErrorUUID.

OK, wonder where they went. ;) It was certainly a better pattern (stable IDs,
not needing to reshuffle tests and c++ in parallel). OK to drop it. Once we get
to upstreaming tests it won't be feasible to change IDs easily - so the current
pattern needs to die before that.

https://codereview.chromium.org/2727683003/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2727683003/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:111618: +  <int value="10"
label="(Obsolete) Invalid Attribute Length"/>
On 2017/03/08 01:46:10, ortuno wrote:
> On 2017/03/07 at 06:20:22, scheib wrote:
> > Where are these being reported from --- do we need to preserve the old
> histogram value mapping? The bluetooth_device.h change doesn't:
> >
>
https://codereview.chromium.org/2727683003/diff/60001/device/bluetooth/blueto...
> 
> These are coming from connectGATT's outcome[1]. We have no instances[2] of any
> of these values being reported so I think it's safe to remove them from the
enum
> and the histogram.
> 
> Done.
> 
> [1]
>
https://cs.chromium.org/chromium/src/content/browser/bluetooth/bluetooth_metr...
> 
> [2]
>
https://uma.googleplex.com/p/chrome/timeline_v2/?sid=292d822142f075ead13389b4...

OK. You can see if metrics folk will let that fly, might get hung up.

[scheib, 2017-03-08 02:36:20]

lgtm

[ortuno, 2017-03-08 02:40:36]

ortuno@chromium.org changed reviewers:
+ isherman@chromium.org

[ortuno, 2017-03-08 02:40:37]

isherman: PTAL at histograms.xml

https://codereview.chromium.org/2727683003/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2727683003/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:112684: -  <int value="10"
label="Invalid Attribute Length"/>
Instead of marking these as obsolete and maintaining the C++ enum with these
obsolete values I opted for deleting all these values. There are no instances of
any of these values[1]. Is this OK?

[1]
https://uma.googleplex.com/p/chrome/timeline_v2/?sid=292d822142f075ead13389b4...

[Ilya Sherman, 2017-03-08 02:51:58]

histograms.xml lgtm

https://codereview.chromium.org/2727683003/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/2727683003/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:112684: -  <int value="10"
label="Invalid Attribute Length"/>
On 2017/03/08 02:40:37, ortuno wrote:
> Instead of marking these as obsolete and maintaining the C++ enum with these
> obsolete values I opted for deleting all these values. There are no instances
of
> any of these values[1]. Is this OK?
> 
> [1]
>
https://uma.googleplex.com/p/chrome/timeline_v2/?sid=292d822142f075ead13389b4...

As long as these were never actually recorded, removing them seems fine, yes. 
Thanks for double-checking that!

[commit-bot: I haz the power, 2017-03-08 02:54:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 02:54:07]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ortuno, 2017-03-08 09:08:16]

ortuno@chromium.org changed reviewers:
+ dcheng@chromium.org, rockot@chromium.org, stevenjb@chromium.org

[ortuno, 2017-03-08 09:08:17]

owners review please:

rockot:

chrome/browser/extensions/api/bluetooth_low_energy
extensions/browser/api/bluetooth_low_energy
extensions/common/api/bluetooth_private.idl

stevenjb:

chrome/browser/resources/options/
chrome/browser/ui/webui/options/
third_party/closure_compiler/externs/bluetooth_private.js

dcheng:

device/bluetooth/public/interfaces/adapter.mojom
device/bluetooth/public/interfaces/connect_result_type_converter.h
third_party/WebKit/public/platform/modules/bluetooth/web_bluetooth.mojom

[stevenjb, 2017-03-08 17:16:22]

owner lgtm

[Ken Rockot(use gerrit already), 2017-03-08 17:44:25]

lgtm

[dcheng, 2017-03-08 22:31:07]

lgtm

[ortuno, 2017-03-09 02:21:38]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2017-03-09 02:21:39]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
stevenjb@chromium.org, isherman@chromium.org, dcheng@chromium.org,
scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2727683003/#ps100001
(title: "merge")

[commit-bot: I haz the power, 2017-03-09 02:22:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-09 02:56:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-09 02:56:39]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ortuno, 2017-03-14 02:07:50]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2017-03-14 02:08:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 03:47:13]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1489457270616630,
"parent_rev": "f8048e8c5f723bd7959a2b2faebead9d47a9c0da", "commit_rev":
"9187d13054b869580045f81d8d55f84c6cf150fa"}

[commit-bot: I haz the power, 2017-03-14 03:47:54]

Description was changed from

==========
bluetooth: Clean up connection error messages

Android documentation is incomplete when it comes to connection error codes,
which led us to believe that all values documented here[1] could be returned
by the platform. We opened http://crbug.com/531058 to include all these values
in our ConnectErrorCode enum.

http://crrev.com/1464443002 was then submitted to include all these values in 
our enum.

Upon further investigation we realized that these values were not being returned
by the platform and needed to be removed from our ConnectErrorCode enum.

This patch reverts the changes in http://crrev.com/1464443002 which means:

1. Removing the values from the enum
2. Changing all clients' switch statements that used the enum
3. Fixing test that used these values
4. Removing strings that described these errors


Also http://crrev.com/1464443002 broke a test this patch also fixes that test.

[1] https://developer.android.com/reference/android/bluetooth/BluetoothGatt.html

BUG=598341, 578191
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
bluetooth: Clean up connection error messages

Android documentation is incomplete when it comes to connection error codes,
which led us to believe that all values documented here[1] could be returned
by the platform. We opened http://crbug.com/531058 to include all these values
in our ConnectErrorCode enum.

http://crrev.com/1464443002 was then submitted to include all these values in 
our enum.

Upon further investigation we realized that these values were not being returned
by the platform and needed to be removed from our ConnectErrorCode enum.

This patch reverts the changes in http://crrev.com/1464443002 which means:

1. Removing the values from the enum
2. Changing all clients' switch statements that used the enum
3. Fixing test that used these values
4. Removing strings that described these errors


Also http://crrev.com/1464443002 broke a test this patch also fixes that test.

[1] https://developer.android.com/reference/android/bluetooth/BluetoothGatt.html

BUG=598341, 578191
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2727683003
Cr-Commit-Position: refs/heads/master@{#456617}
Committed:
https://chromium.googlesource.com/chromium/src/+/9187d13054b869580045f81d8d55...
==========

[commit-bot: I haz the power, 2017-03-14 03:47:56]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/9187d13054b869580045f81d8d55...