extensions/browser/api/bluetooth/bluetooth_private_api.cc - Issue 2727683003: bluetooth: Clean up connection errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/bluetooth/bluetooth_private_api.cc

Issue 2727683003: bluetooth: Clean up connection errors (Closed)

Patch Set: merge Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « device/bluetooth/public/interfaces/connect_result_type_converter.h ('k') | extensions/browser/api/bluetooth_low_energy/bluetooth_low_energy_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/bluetooth/bluetooth_private_api.cc

diff --git a/extensions/browser/api/bluetooth/bluetooth_private_api.cc b/extensions/browser/api/bluetooth/bluetooth_private_api.cc

index ac1da95e3e3b6ddfb2a910c97ad919560234eba8..8de965d4bdcbd3e0f48dbbf0bba30e13bd249a19 100644

--- a/extensions/browser/api/bluetooth/bluetooth_private_api.cc

+++ b/extensions/browser/api/bluetooth/bluetooth_private_api.cc

@@ -516,9 +516,6 @@ void BluetoothPrivateConnectFunction::OnErrorCallback(

device::BluetoothDevice::ConnectErrorCode error) {

bt_private::ConnectResultType result = bt_private::CONNECT_RESULT_TYPE_NONE;

switch (error) {

- case device::BluetoothDevice::ERROR_ATTRIBUTE_LENGTH_INVALID:

- result = bt_private::CONNECT_RESULT_TYPE_ATTRIBUTELENGTHINVALID;

- break;

case device::BluetoothDevice::ERROR_AUTH_CANCELED:

result = bt_private::CONNECT_RESULT_TYPE_AUTHCANCELED;

break;

@@ -531,36 +528,18 @@ void BluetoothPrivateConnectFunction::OnErrorCallback(

case device::BluetoothDevice::ERROR_AUTH_TIMEOUT:

result = bt_private::CONNECT_RESULT_TYPE_AUTHTIMEOUT;

break;

- case device::BluetoothDevice::ERROR_CONNECTION_CONGESTED:

- result = bt_private::CONNECT_RESULT_TYPE_CONNECTIONCONGESTED;

- break;

case device::BluetoothDevice::ERROR_FAILED:

result = bt_private::CONNECT_RESULT_TYPE_FAILED;

break;

case device::BluetoothDevice::ERROR_INPROGRESS:

result = bt_private::CONNECT_RESULT_TYPE_INPROGRESS;

break;

- case device::BluetoothDevice::ERROR_INSUFFICIENT_ENCRYPTION:

- result = bt_private::CONNECT_RESULT_TYPE_INSUFFICIENTENCRYPTION;

- break;

- case device::BluetoothDevice::ERROR_OFFSET_INVALID:

- result = bt_private::CONNECT_RESULT_TYPE_OFFSETINVALID;

- break;

- case device::BluetoothDevice::ERROR_READ_NOT_PERMITTED:

- result = bt_private::CONNECT_RESULT_TYPE_READNOTPERMITTED;

- break;

- case device::BluetoothDevice::ERROR_REQUEST_NOT_SUPPORTED:

- result = bt_private::CONNECT_RESULT_TYPE_REQUESTNOTSUPPORTED;

- break;

case device::BluetoothDevice::ERROR_UNKNOWN:

result = bt_private::CONNECT_RESULT_TYPE_UNKNOWNERROR;

break;

case device::BluetoothDevice::ERROR_UNSUPPORTED_DEVICE:

result = bt_private::CONNECT_RESULT_TYPE_UNSUPPORTEDDEVICE;

break;

- case device::BluetoothDevice::ERROR_WRITE_NOT_PERMITTED:

- result = bt_private::CONNECT_RESULT_TYPE_WRITENOTPERMITTED;

- break;

case device::BluetoothDevice::NUM_CONNECT_ERROR_CODES:

NOTREACHED();

break;