Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1309)

Unified Diff: chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc

Issue 2727683003: bluetooth: Clean up connection errors (Closed)
Patch Set: merge Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc
diff --git a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc
index 7cb0a30d44149e952a43fc6b24a58afe69226523..4d6b2197c302a26800c320a6f408699c591256a7 100644
--- a/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc
+++ b/chrome/browser/extensions/api/bluetooth_low_energy/bluetooth_low_energy_apitest.cc
@@ -1144,10 +1144,11 @@ IN_PROC_BROWSER_TEST_F(BluetoothLowEnergyApiTest, GattConnection) {
.WillRepeatedly(Return(device0_.get()));
EXPECT_CALL(*mock_adapter_, GetDevice(kTestLeDeviceAddress1))
.WillRepeatedly(Return(device1_.get()));
- static_assert(BluetoothDevice::NUM_CONNECT_ERROR_CODES == 15,
+ static_assert(
+ BluetoothDevice::NUM_CONNECT_ERROR_CODES == 8,
"Update required if the number of BluetoothDevice enums changes.");
EXPECT_CALL(*device0_, CreateGattConnection(_, _))
- .Times(16)
+ .Times(9)
.WillOnce(InvokeCallbackArgument<1>(BluetoothDevice::ERROR_FAILED))
.WillOnce(InvokeCallbackArgument<1>(BluetoothDevice::ERROR_INPROGRESS))
.WillOnce(InvokeCallbackArgument<1>(BluetoothDevice::ERROR_AUTH_FAILED))
@@ -1156,20 +1157,6 @@ IN_PROC_BROWSER_TEST_F(BluetoothLowEnergyApiTest, GattConnection) {
.WillOnce(InvokeCallbackArgument<1>(BluetoothDevice::ERROR_AUTH_TIMEOUT))
.WillOnce(
InvokeCallbackArgument<1>(BluetoothDevice::ERROR_UNSUPPORTED_DEVICE))
- .WillOnce(InvokeCallbackArgument<1>(
- BluetoothDevice::ERROR_ATTRIBUTE_LENGTH_INVALID))
- .WillOnce(InvokeCallbackArgument<1>(
- BluetoothDevice::ERROR_CONNECTION_CONGESTED))
- .WillOnce(InvokeCallbackArgument<1>(
- BluetoothDevice::ERROR_INSUFFICIENT_ENCRYPTION))
- .WillOnce(
- InvokeCallbackArgument<1>(BluetoothDevice::ERROR_OFFSET_INVALID))
- .WillOnce(InvokeCallbackArgument<1>(
- BluetoothDevice::ERROR_READ_NOT_PERMITTED))
- .WillOnce(InvokeCallbackArgument<1>(
- BluetoothDevice::ERROR_REQUEST_NOT_SUPPORTED))
- .WillOnce(InvokeCallbackArgument<1>(
- BluetoothDevice::ERROR_WRITE_NOT_PERMITTED))
.WillOnce(InvokeCallbackWithScopedPtrArg<0, BluetoothGattConnection>(
CreateGattConnection(mock_adapter_, kTestLeDeviceAddress0,
true /* expect_disconnect */)))
« no previous file with comments | « chrome/app/chromeos_strings.grdp ('k') | chrome/browser/resources/options/chromeos/bluetooth_pair_device_overlay.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698