Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2727683002: Fix unit tests to enable them testing with the rAF aligned touch input. (Closed)

Created:
3 years, 9 months ago by dtapuska
Modified:
3 years, 9 months ago
Reviewers:
tdresser
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, dtapuska+chromiumwatch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix unit tests to enable them testing with the rAF aligned touch input. rAF aligned touch input enables a passthrough touch event queue and a number of tests were testing the number of ACKs or messages sent. Explicitly enable the tests so that it is independent of the actual feature setting. In certain test cases run both the rAF enabled and disabled. For tests where it doesn't really matter just enable it. Most of the changes here are related to GestureScrollUpdate which then generates 2 messages sent immediately (instead of 1 sent and 1 queued). BUG=642368 Review-Url: https://codereview.chromium.org/2727683002 Cr-Commit-Position: refs/heads/master@{#454243} Committed: https://chromium.googlesource.com/chromium/src/+/48e55aa69627f177a523bbf80f753454764ac2ac

Patch Set 1 #

Patch Set 2 : Fix failure in debug mode #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+300 lines, -73 lines) Patch
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 2 13 chunks +54 lines, -16 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_unittest.cc View 9 chunks +41 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 17 chunks +129 lines, -12 lines 0 comments Download
M content/renderer/input/input_event_filter_unittest.cc View 14 chunks +65 lines, -36 lines 0 comments Download
M content/renderer/input/input_handler_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/input/main_thread_event_queue_unittest.cc View 1 chunk +10 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 15 (10 generated)
dtapuska
3 years, 9 months ago (2017-03-01 20:36:21 UTC) #6
tdresser
LGTM
3 years, 9 months ago (2017-03-02 12:59:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2727683002/40001
3 years, 9 months ago (2017-03-02 13:01:22 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/48e55aa69627f177a523bbf80f753454764ac2ac
3 years, 9 months ago (2017-03-02 13:07:54 UTC) #14
dtapuska
3 years, 9 months ago (2017-03-03 01:54:37 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2725263002/ by dtapuska@chromium.org.

The reason for reverting is: Rolling back passthrough event queue being
enabled..

Powered by Google App Engine
This is Rietveld 408576698