Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2724743004: Reset the touch-action on the touch gesture end sequence. (Closed)

Created:
3 years, 9 months ago by dtapuska
Modified:
3 years, 9 months ago
Reviewers:
tdresser, Rick Byers
CC:
chromium-reviews, jam, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reset the touch-action on the touch gesture end sequence. This makes the property that the touch-action is always adjusted on receiving touch ack. Change https://codereview.chromium.org/2715623002 broke the property that a single touch action was outstanding. This caused issues with a delayed touch-end handler possibly and another touchstart being issued the touch-action would have been reset intermitently there. There is already a test that covers this and it will be apparent when the test is modified to support rAF aligned input enabled (which then turns on the pass through touch event queue). BUG=624368 Review-Url: https://codereview.chromium.org/2724743004 Cr-Commit-Position: refs/heads/master@{#454036} Committed: https://chromium.googlesource.com/chromium/src/+/783059297a429d72f45dc835a738233139d822f7

Patch Set 1 #

Patch Set 2 : Add test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -11 lines) Patch
M content/browser/renderer_host/input/input_router_impl.cc View 2 chunks +6 lines, -9 lines 0 comments Download
M content/browser/renderer_host/input/input_router_impl_unittest.cc View 1 6 chunks +87 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (12 generated)
dtapuska
I discussed this with Rick as a potential fallout of my change earlier this week.
3 years, 9 months ago (2017-03-01 16:23:52 UTC) #5
tdresser
Could we update the test for this as part of this patch?
3 years, 9 months ago (2017-03-01 16:45:36 UTC) #6
dtapuska
On 2017/03/01 16:45:36, tdresser wrote: > Could we update the test for this as part ...
3 years, 9 months ago (2017-03-01 16:52:00 UTC) #7
dtapuska
On 2017/03/01 16:52:00, dtapuska wrote: > On 2017/03/01 16:45:36, tdresser wrote: > > Could we ...
3 years, 9 months ago (2017-03-01 20:23:35 UTC) #11
tdresser
LGTM, thanks.
3 years, 9 months ago (2017-03-01 20:30:03 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2724743004/20001
3 years, 9 months ago (2017-03-01 20:34:30 UTC) #16
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 21:25:54 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/783059297a429d72f45dc835a738...

Powered by Google App Engine
This is Rietveld 408576698