Move task.describe to audit.define arg

Move task.describe to audit.define arg

Manually changed all calls to task.describe to move the description to
audit.define.

Also used clang-format to reformat code due to adding the dictionary
arg for audit.define.  For a few tests, the description was slightyl
modified to be more concise.  For dom-execptions, some task.describe
strings were removed since they were redundant, being the same as the
test label.

BUG=694659
TEST=no change in expected results; just changes in messages

Review-Url: https://codereview.chromium.org/2727663003
Cr-Commit-Position: refs/heads/master@{#457890}
Committed: https://chromium.googlesource.com/chromium/src/+/2f8decb30a8027145aa003cc7cf7ae5d094e9695

[Raymond Toy, 2017-03-01 17:59:28]

rtoy@chromium.org changed reviewers:
+ hongchan@chromium.org

[Raymond Toy, 2017-03-01 17:59:29]

PTAL.  This should remove all task.describe usages.  Should I remove
task.describe from audit now too?

[hongchan, 2017-03-03 15:52:21]

Yes, removing task.describe() should be included here.

https://codereview.chromium.org/2727663003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold.html
(right):

https://codereview.chromium.org/2727663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold.html:67:
{label: 'setTarget', descrition: 'Cancel setTargetAtTime'},
Hmm. Is this done manually? A typo in "descrition".

https://codereview.chromium.org/2727663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold.html:284:
audit.define('post cancel: ValueCurve', function(task, should) {
This hasn't changed.

https://codereview.chromium.org/2727663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold.html:309:
audit.define('post cancel: setTarget', function(task, should) {
Ditto.

https://codereview.chromium.org/2727663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold.html:334:
audit.define('post cancel: setValue', function(task, should) {
Ditto.

https://codereview.chromium.org/2727663003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/dom-exceptions.html (right):

https://codereview.chromium.org/2727663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/dom-exceptions.html:602:
audit.define('convolver', (task, should) => {
Are we fine with no description?

https://codereview.chromium.org/2727663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/dom-exceptions.html:625:
audit.define('panner', (task, should) => {
And here too?

https://codereview.chromium.org/2727663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/dom-exceptions.html:651:
audit.define('script-processor', (task, should) => {
Ditto.

[Raymond Toy, 2017-03-03 18:38:04]

https://codereview.chromium.org/2727663003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold.html
(right):

https://codereview.chromium.org/2727663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold.html:67:
{label: 'setTarget', descrition: 'Cancel setTargetAtTime'},
On 2017/03/03 15:52:21, hongchan wrote:
> Hmm. Is this done manually? A typo in "descrition".
Yes, this was all done manually.

https://codereview.chromium.org/2727663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/AudioParam/audioparam-cancel-and-hold.html:284:
audit.define('post cancel: ValueCurve', function(task, should) {
On 2017/03/03 15:52:21, hongchan wrote:
> This hasn't changed.

There was no task.describe for this already, so I didn't see the need to make
this an dictionary.  Are we going to make the dictionary mandatory in the
future?

https://codereview.chromium.org/2727663003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/webaudio/dom-exceptions.html (right):

https://codereview.chromium.org/2727663003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/dom-exceptions.html:625:
audit.define('panner', (task, should) => {
On 2017/03/03 15:52:21, hongchan wrote:
> And here too?

While there is a task.describe, it basically added no new information. I suspect
I did this to get the description and label printed which wasn't working before.

[hongchan, 2017-03-07 16:50:26]

Sorry for the late response. lgtm

[Raymond Toy, 2017-03-07 16:52:29]

The CQ bit was checked by rtoy@chromium.org

[commit-bot: I haz the power, 2017-03-07 16:53:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 18:07:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 18:07:45]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Raymond Toy, 2017-03-07 18:19:40]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-03-07 18:19:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2727663003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-07 18:21:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 19:31:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 19:31:13]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Raymond Toy, 2017-03-08 21:33:19]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-03-08 21:33:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2727663003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-08 21:33:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-08 22:48:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-08 22:48:01]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Raymond Toy, 2017-03-17 17:50:53]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-03-17 17:50:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2727663003/#ps140001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-17 17:51:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 18:52:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 18:52:39]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Raymond Toy, 2017-03-17 20:36:08]

The CQ bit was checked by rtoy@chromium.org

[Raymond Toy, 2017-03-17 20:36:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
hongchan@chromium.org
Link to the patchset: https://codereview.chromium.org/2727663003/#ps160001
(title: "Fix up expected results")

[commit-bot: I haz the power, 2017-03-17 20:36:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 21:42:14]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1489782968675290,
"parent_rev": "0e89702abe2235bfb1bc778444d2eb2f166567ad", "commit_rev":
"2f8decb30a8027145aa003cc7cf7ae5d094e9695"}

[commit-bot: I haz the power, 2017-03-17 21:43:13]

Description was changed from

==========
Move task.describe to audit.define arg

Manually changed all calls to task.describe to move the description to
audit.define.

Also used clang-format to reformat code due to adding the dictionary
arg for audit.define.  For a few tests, the description was slightyl
modified to be more concise.  For dom-execptions, some task.describe
strings were removed since they were redundant, being the same as the
test label.

BUG=694659
TEST=no change in expected results; just changes in messages
==========

to

==========
Move task.describe to audit.define arg

Manually changed all calls to task.describe to move the description to
audit.define.

Also used clang-format to reformat code due to adding the dictionary
arg for audit.define.  For a few tests, the description was slightyl
modified to be more concise.  For dom-execptions, some task.describe
strings were removed since they were redundant, being the same as the
test label.

BUG=694659
TEST=no change in expected results; just changes in messages

Review-Url: https://codereview.chromium.org/2727663003
Cr-Commit-Position: refs/heads/master@{#457890}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f8decb30a8027145aa003cc7cf7...
==========

[commit-bot: I haz the power, 2017-03-17 21:43:14]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/2f8decb30a8027145aa003cc7cf7...