Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html

Issue 2727663003: Move task.describe to audit.define arg (Closed)
Patch Set: Fix up expected results Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html
diff --git a/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html b/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html
index cafb81ddd2d561d8d21ca5d8a766f74528897363..20b31fe8fa6c00c0b72acd82564371e6365b05f5 100644
--- a/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html
+++ b/third_party/WebKit/LayoutTests/webaudio/Delay/delaynode-maxdelay.html
@@ -13,32 +13,39 @@
<script>
let audit = Audit.createTaskRunner();
-audit.define("test", function (task, should) {
- task.describe(
- "Basic functionality of DelayNode with a non-default max delay time")
-
- // Create offline audio context.
- var context = new OfflineAudioContext(1, sampleRate * renderLengthSeconds, sampleRate);
- var toneBuffer = createToneBuffer(context, 20, 20 * toneLengthSeconds, sampleRate); // 20Hz tone
-
- var bufferSource = context.createBufferSource();
- bufferSource.buffer = toneBuffer;
-
- // Create a delay node with an explicit max delay time (greater than the default of 1 second).
- var delay = context.createDelay(2);
- // Set the delay time to a value greater than the default max delay so we can verify the delay
- // is working for this case.
- delayTimeSeconds = 1.5;
- delay.delayTime.value = delayTimeSeconds;
-
- bufferSource.connect(delay);
- delay.connect(context.destination);
- bufferSource.start(0);
-
- context.startRendering()
- .then(buffer => checkDelayedResult(buffer, toneBuffer, should))
- .then(() => task.done());
-});
+audit.define(
+ {
+ label: 'test',
+ description:
+ 'Basic functionality of DelayNode with a non-default max delay time'
+ },
+ function(task, should) {
+
+ // Create offline audio context.
+ var context = new OfflineAudioContext(
+ 1, sampleRate * renderLengthSeconds, sampleRate);
+ var toneBuffer = createToneBuffer(
+ context, 20, 20 * toneLengthSeconds, sampleRate); // 20Hz tone
+
+ var bufferSource = context.createBufferSource();
+ bufferSource.buffer = toneBuffer;
+
+ // Create a delay node with an explicit max delay time (greater than the
+ // default of 1 second).
+ var delay = context.createDelay(2);
+ // Set the delay time to a value greater than the default max delay so we
+ // can verify the delay is working for this case.
+ delayTimeSeconds = 1.5;
+ delay.delayTime.value = delayTimeSeconds;
+
+ bufferSource.connect(delay);
+ delay.connect(context.destination);
+ bufferSource.start(0);
+
+ context.startRendering()
+ .then(buffer => checkDelayedResult(buffer, toneBuffer, should))
+ .then(() => task.done());
+ });
audit.run();
</script>

Powered by Google App Engine
This is Rietveld 408576698