cc: Specify rasterization color space

cc: Specify rasterization color space

Specify to use nonlinear blended color spaces for rasterization.

Add gfx::ColorSpace accessor to create this SkColorSpace.

BUG=697675
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2727063002
Cr-Commit-Position: refs/heads/master@{#454499}
Committed: https://chromium.googlesource.com/chromium/src/+/f1d1869a2f3bd20a7eb37461df98eae8f7213de6

[ccameron, 2017-03-02 00:34:59]

Description was changed from

==========
cc: Specify rasterization color space

Specify to use nonlinear blended color spaces for rasterization.

Add gfx::ColorSpace accessor to create this SkColorSpace.

BUG=697675
==========

to

==========
cc: Specify rasterization color space

Specify to use nonlinear blended color spaces for rasterization.

Add gfx::ColorSpace accessor to create this SkColorSpace.

BUG=697675
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[ccameron, 2017-03-02 00:35:26]

ccameron@chromium.org changed reviewers:
+ enne@chromium.org

[ccameron, 2017-03-02 00:35:26]

ptal -- using the new Skia API for color conversion

[enne (OOO), 2017-03-02 01:40:08]

lgtm

https://codereview.chromium.org/2727063002/diff/1/cc/resources/resource_provi...
File cc/resources/resource_provider.cc (right):

https://codereview.chromium.org/2727063002/diff/1/cc/resources/resource_provi...
cc/resources/resource_provider.cc:887: return
resource->color_space.ToNonlinearBlendedSkColorSpace();
Could you leave a comment as to why we're using this here vs ToSkColorSpace?
Future code archaeologists will appreciate it.

https://codereview.chromium.org/2727063002/diff/1/ui/gfx/color_space.h
File ui/gfx/color_space.h (right):

https://codereview.chromium.org/2727063002/diff/1/ui/gfx/color_space.h#newcod...
ui/gfx/color_space.h:149: // function.
missing parenthesis here

[ccameron, 2017-03-02 04:11:08]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 04:12:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 06:04:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 06:04:10]

Dry run: Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[ccameron, 2017-03-02 22:55:22]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 22:56:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-03-03 00:32:31]

The CQ bit was unchecked by ccameron@chromium.org

[ccameron, 2017-03-03 00:36:04]

https://codereview.chromium.org/2727063002/diff/1/cc/resources/resource_provi...
File cc/resources/resource_provider.cc (right):

https://codereview.chromium.org/2727063002/diff/1/cc/resources/resource_provi...
cc/resources/resource_provider.cc:887: return
resource->color_space.ToNonlinearBlendedSkColorSpace();
On 2017/03/02 01:40:08, enne wrote:
> Could you leave a comment as to why we're using this here vs ToSkColorSpace?
> Future code archaeologists will appreciate it.

Done.

https://codereview.chromium.org/2727063002/diff/1/ui/gfx/color_space.h
File ui/gfx/color_space.h (right):

https://codereview.chromium.org/2727063002/diff/1/ui/gfx/color_space.h#newcod...
ui/gfx/color_space.h:149: // function.
On 2017/03/02 01:40:08, enne wrote:
> missing parenthesis here

Done.

[ccameron, 2017-03-03 00:36:16]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-03-03 00:36:16]

The patchset sent to the CQ was uploaded after l-g-t-m from enne@chromium.org
Link to the patchset: https://codereview.chromium.org/2727063002/#ps60001
(title: "Add comment")

[commit-bot: I haz the power, 2017-03-03 00:36:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 03:22:49]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488501376425440,
"parent_rev": "bbb3bb2234561db8ddf52e905770e4109c56ae28", "commit_rev":
"f1d1869a2f3bd20a7eb37461df98eae8f7213de6"}

[commit-bot: I haz the power, 2017-03-03 03:23:32]

Description was changed from

==========
cc: Specify rasterization color space

Specify to use nonlinear blended color spaces for rasterization.

Add gfx::ColorSpace accessor to create this SkColorSpace.

BUG=697675
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
cc: Specify rasterization color space

Specify to use nonlinear blended color spaces for rasterization.

Add gfx::ColorSpace accessor to create this SkColorSpace.

BUG=697675
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2727063002
Cr-Commit-Position: refs/heads/master@{#454499}
Committed:
https://chromium.googlesource.com/chromium/src/+/f1d1869a2f3bd20a7eb37461df98...
==========

[commit-bot: I haz the power, 2017-03-03 03:23:33]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/f1d1869a2f3bd20a7eb37461df98...