color: Remove blink pre-conversion code

color: Remove blink pre-conversion code

This removes ColorBehavior as a parameter to Image::draw. We will be
specifying color behavior on the SkSurface that we render to, so this
parameter is unneeded.

Make most callers to ColorBehavior specify ColorBehavior::defaultBehavior,
which will check runtime parameters to decide if pre-conversion or tagging
is appropriate.

Delete all references to "true color mode" -- Blink will not behave differently
in the two modes (it will always tag its inputs with their SkColorSpace).

Leave ColorBehavior as an argument to ImageDecoder, because some
interfaces (WebGL in particular) will want to specify the "ignore" behavior.

Don't remove ColorBehavior as an argument to imageForCurrentFrame, at
least yet. The SkImage created will need to specify some color space,
and allowing the caller to parameterize that is reasonable.

R=junov,chrishtr
TBR=esprehn
BUG=667411
BUG=667420
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2712083002
Cr-Commit-Position: refs/heads/master@{#454155}
Committed: https://chromium.googlesource.com/chromium/src/+/0713546fe2092b05fb75c52ba9da223adda2681f

[ccameron, 2017-02-24 03:29:37]

Description was changed from

==========
color: Remove blink pre-conversion code


BUG=
==========

to

==========
color: Remove blink pre-conversion code


BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2017-02-24 03:29:43]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 03:30:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-02-24 04:59:49]

Description was changed from

==========
color: Remove blink pre-conversion code


BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
color: Remove blink pre-conversion code

This removes ColorBehavior as a parameter to Image::draw. We will be
specifying color behavior on the SkSurface that we render to, so this
parameter is unneeded.

Make most callers to ColorBehavior specify ColorBehavior::defaultBehavior,
which will check runtime parameters to decide if pre-conversion or tagging
is appropriate.

Delete all references to "true color mode" -- Blink will not behave differently
in the two modes (it will always tag its inputs with their SkColorSpace).

Leave ColorBehavior as an argument to ImageDecoder, because some
interfaces (WebGL in particular) will want to specify the "ignore" behavior.

Don't remove ColorBehavior as an argument to imageForCurrentFrame, at
least yet. The SkImage created will need to specify some color space,
and allowing the caller to parameterize that is reasonable.

BUG=667411
==========

[ccameron, 2017-02-24 04:59:49]

ccameron@chromium.org changed reviewers:
+ chrishtr@chromium.org, junov@chromium.org

[ccameron, 2017-02-24 05:01:10]

Description was changed from

==========
color: Remove blink pre-conversion code

This removes ColorBehavior as a parameter to Image::draw. We will be
specifying color behavior on the SkSurface that we render to, so this
parameter is unneeded.

Make most callers to ColorBehavior specify ColorBehavior::defaultBehavior,
which will check runtime parameters to decide if pre-conversion or tagging
is appropriate.

Delete all references to "true color mode" -- Blink will not behave differently
in the two modes (it will always tag its inputs with their SkColorSpace).

Leave ColorBehavior as an argument to ImageDecoder, because some
interfaces (WebGL in particular) will want to specify the "ignore" behavior.

Don't remove ColorBehavior as an argument to imageForCurrentFrame, at
least yet. The SkImage created will need to specify some color space,
and allowing the caller to parameterize that is reasonable.

BUG=667411
==========

to

==========
color: Remove blink pre-conversion code

This removes ColorBehavior as a parameter to Image::draw. We will be
specifying color behavior on the SkSurface that we render to, so this
parameter is unneeded.

Make most callers to ColorBehavior specify ColorBehavior::defaultBehavior,
which will check runtime parameters to decide if pre-conversion or tagging
is appropriate.

Delete all references to "true color mode" -- Blink will not behave differently
in the two modes (it will always tag its inputs with their SkColorSpace).

Leave ColorBehavior as an argument to ImageDecoder, because some
interfaces (WebGL in particular) will want to specify the "ignore" behavior.

Don't remove ColorBehavior as an argument to imageForCurrentFrame, at
least yet. The SkImage created will need to specify some color space,
and allowing the caller to parameterize that is reasonable.

BUG=667411
BUG=667420
==========

[commit-bot: I haz the power, 2017-02-24 05:25:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 05:25:02]

Dry run: This issue passed the CQ dry run.

[Justin Novosad, 2017-02-27 20:35:07]

Agree 100% with this approach lgtm

[ccameron, 2017-02-28 17:25:21]

Description was changed from

==========
color: Remove blink pre-conversion code

This removes ColorBehavior as a parameter to Image::draw. We will be
specifying color behavior on the SkSurface that we render to, so this
parameter is unneeded.

Make most callers to ColorBehavior specify ColorBehavior::defaultBehavior,
which will check runtime parameters to decide if pre-conversion or tagging
is appropriate.

Delete all references to "true color mode" -- Blink will not behave differently
in the two modes (it will always tag its inputs with their SkColorSpace).

Leave ColorBehavior as an argument to ImageDecoder, because some
interfaces (WebGL in particular) will want to specify the "ignore" behavior.

Don't remove ColorBehavior as an argument to imageForCurrentFrame, at
least yet. The SkImage created will need to specify some color space,
and allowing the caller to parameterize that is reasonable.

BUG=667411
BUG=667420
==========

to

==========
color: Remove blink pre-conversion code

This removes ColorBehavior as a parameter to Image::draw. We will be
specifying color behavior on the SkSurface that we render to, so this
parameter is unneeded.

Make most callers to ColorBehavior specify ColorBehavior::defaultBehavior,
which will check runtime parameters to decide if pre-conversion or tagging
is appropriate.

Delete all references to "true color mode" -- Blink will not behave differently
in the two modes (it will always tag its inputs with their SkColorSpace).

Leave ColorBehavior as an argument to ImageDecoder, because some
interfaces (WebGL in particular) will want to specify the "ignore" behavior.

Don't remove ColorBehavior as an argument to imageForCurrentFrame, at
least yet. The SkImage created will need to specify some color space,
and allowing the caller to parameterize that is reasonable.

BUG=667411
BUG=667420
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2017-02-28 17:46:26]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 17:46:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 19:27:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 19:27:02]

Dry run: This issue passed the CQ dry run.

[chrishtr, 2017-02-28 21:21:27]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-02-28 21:21:28]

lgtm

https://codereview.chromium.org/2712083002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp (left):

https://codereview.chromium.org/2712083002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp:831:
Image::ClampImageToSourceRect, m_colorBehavior);
Remove m_colorBehavior entirely?

[chrishtr, 2017-02-28 21:21:29]

The patchset sent to the CQ was uploaded after l-g-t-m from junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2712083002/#ps20001
(title: "git cl try")

[chrishtr, 2017-02-28 21:21:31]

The CQ bit was unchecked by chrishtr@chromium.org

[ccameron, 2017-03-01 20:40:33]

https://codereview.chromium.org/2712083002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp (left):

https://codereview.chromium.org/2712083002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp:831:
Image::ClampImageToSourceRect, m_colorBehavior);
On 2017/02/28 21:21:28, chrishtr wrote:
> Remove m_colorBehavior entirely?

Mmh, good point. Took out a little bit more.

[ccameron, 2017-03-01 20:41:30]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 20:42:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Justin Novosad, 2017-03-01 20:42:40]

Nice!

re-lgtm

[chrishtr, 2017-03-01 20:56:11]

lgtm

[ccameron, 2017-03-01 21:25:18]

Description was changed from

==========
color: Remove blink pre-conversion code

This removes ColorBehavior as a parameter to Image::draw. We will be
specifying color behavior on the SkSurface that we render to, so this
parameter is unneeded.

Make most callers to ColorBehavior specify ColorBehavior::defaultBehavior,
which will check runtime parameters to decide if pre-conversion or tagging
is appropriate.

Delete all references to "true color mode" -- Blink will not behave differently
in the two modes (it will always tag its inputs with their SkColorSpace).

Leave ColorBehavior as an argument to ImageDecoder, because some
interfaces (WebGL in particular) will want to specify the "ignore" behavior.

Don't remove ColorBehavior as an argument to imageForCurrentFrame, at
least yet. The SkImage created will need to specify some color space,
and allowing the caller to parameterize that is reasonable.

BUG=667411
BUG=667420
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
color: Remove blink pre-conversion code

This removes ColorBehavior as a parameter to Image::draw. We will be
specifying color behavior on the SkSurface that we render to, so this
parameter is unneeded.

Make most callers to ColorBehavior specify ColorBehavior::defaultBehavior,
which will check runtime parameters to decide if pre-conversion or tagging
is appropriate.

Delete all references to "true color mode" -- Blink will not behave differently
in the two modes (it will always tag its inputs with their SkColorSpace).

Leave ColorBehavior as an argument to ImageDecoder, because some
interfaces (WebGL in particular) will want to specify the "ignore" behavior.

Don't remove ColorBehavior as an argument to imageForCurrentFrame, at
least yet. The SkImage created will need to specify some color space,
and allowing the caller to parameterize that is reasonable.

R=junov,chrishtr
TBR=esprehn
BUG=667411
BUG=667420
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[ccameron, 2017-03-01 22:09:22]

The CQ bit was unchecked by ccameron@chromium.org

[ccameron, 2017-03-01 22:09:37]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2017-03-01 22:10:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-01 22:25:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-01 22:25:55]

Failed to apply patch for
third_party/WebKit/Source/core/svg/graphics/SVGImage.h:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/Source/core/svg/graphics/SVGImage.h:124
  error: third_party/WebKit/Source/core/svg/graphics/SVGImage.h: patch does not
apply

Patch:       third_party/WebKit/Source/core/svg/graphics/SVGImage.h
Index: third_party/WebKit/Source/core/svg/graphics/SVGImage.h
diff --git a/third_party/WebKit/Source/core/svg/graphics/SVGImage.h
b/third_party/WebKit/Source/core/svg/graphics/SVGImage.h
index
a9b99ede4a3a783ecd667f50cce8fefb08537a00..4f1f91bb0273a25364d75064a93392e4d63e2714
100644
--- a/third_party/WebKit/Source/core/svg/graphics/SVGImage.h
+++ b/third_party/WebKit/Source/core/svg/graphics/SVGImage.h
@@ -124,8 +124,7 @@ class CORE_EXPORT SVGImage final : public Image {
             const FloatRect& fromRect,
             const FloatRect& toRect,
             RespectImageOrientationEnum,
-            ImageClampingMode,
-            const ColorBehavior&) override;
+            ImageClampingMode) override;
   void drawForContainer(PaintCanvas*,
                         const SkPaint&,
                         const FloatSize,

[ccameron, 2017-03-01 22:35:33]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-01 22:36:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2017-03-02 00:24:11]

The CQ bit was unchecked by ccameron@chromium.org

[ccameron, 2017-03-02 00:24:25]

The CQ bit was checked by ccameron@chromium.org

[ccameron, 2017-03-02 00:24:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org, junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2712083002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-02 00:25:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 02:29:34]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488414265514670,
"parent_rev": "c0182b5f45e7161cad9d586b75b66653575f46ce", "commit_rev":
"0713546fe2092b05fb75c52ba9da223adda2681f"}

[commit-bot: I haz the power, 2017-03-02 02:30:14]

Description was changed from

==========
color: Remove blink pre-conversion code

This removes ColorBehavior as a parameter to Image::draw. We will be
specifying color behavior on the SkSurface that we render to, so this
parameter is unneeded.

Make most callers to ColorBehavior specify ColorBehavior::defaultBehavior,
which will check runtime parameters to decide if pre-conversion or tagging
is appropriate.

Delete all references to "true color mode" -- Blink will not behave differently
in the two modes (it will always tag its inputs with their SkColorSpace).

Leave ColorBehavior as an argument to ImageDecoder, because some
interfaces (WebGL in particular) will want to specify the "ignore" behavior.

Don't remove ColorBehavior as an argument to imageForCurrentFrame, at
least yet. The SkImage created will need to specify some color space,
and allowing the caller to parameterize that is reasonable.

R=junov,chrishtr
TBR=esprehn
BUG=667411
BUG=667420
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
color: Remove blink pre-conversion code

This removes ColorBehavior as a parameter to Image::draw. We will be
specifying color behavior on the SkSurface that we render to, so this
parameter is unneeded.

Make most callers to ColorBehavior specify ColorBehavior::defaultBehavior,
which will check runtime parameters to decide if pre-conversion or tagging
is appropriate.

Delete all references to "true color mode" -- Blink will not behave differently
in the two modes (it will always tag its inputs with their SkColorSpace).

Leave ColorBehavior as an argument to ImageDecoder, because some
interfaces (WebGL in particular) will want to specify the "ignore" behavior.

Don't remove ColorBehavior as an argument to imageForCurrentFrame, at
least yet. The SkImage created will need to specify some color space,
and allowing the caller to parameterize that is reasonable.

R=junov,chrishtr
TBR=esprehn
BUG=667411
BUG=667420
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2712083002
Cr-Commit-Position: refs/heads/master@{#454155}
Committed:
https://chromium.googlesource.com/chromium/src/+/0713546fe2092b05fb75c52ba9da...
==========

[commit-bot: I haz the power, 2017-03-02 02:30:16]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/0713546fe2092b05fb75c52ba9da...