Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2726723002: Remove default arguments from V8ScriptRunner::compileScript()s (Closed)

Created:
3 years, 9 months ago by hiroshige
Modified:
3 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove default arguments from V8ScriptRunner::compileScript()s No callsites use the default arguments except for those in unit tests. BUG=686281 Review-Url: https://codereview.chromium.org/2726723002 Cr-Commit-Position: refs/heads/master@{#453983} Committed: https://chromium.googlesource.com/chromium/src/+/1e806b1e34b10601573dc18d6ebfafd40651d40f

Patch Set 1 #

Patch Set 2 : Fix unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -30 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp View 1 5 chunks +15 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h View 1 chunk +22 lines, -25 lines 0 comments Download

Messages

Total messages: 20 (15 generated)
hiroshige
PTAL.
3 years, 9 months ago (2017-02-28 23:31:59 UTC) #5
haraken
LGTM
3 years, 9 months ago (2017-02-28 23:45:00 UTC) #6
hiroshige
On 2017/02/28 23:45:00, haraken wrote: > LGTM Correction: "except for those in unit tests." and ...
3 years, 9 months ago (2017-03-01 01:13:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2726723002/20001
3 years, 9 months ago (2017-03-01 18:47:56 UTC) #17
commit-bot: I haz the power
3 years, 9 months ago (2017-03-01 18:53:46 UTC) #20
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1e806b1e34b10601573dc18d6ebf...

Powered by Google App Engine
This is Rietveld 408576698