Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h

Issue 2726723002: Remove default arguments from V8ScriptRunner::compileScript()s (Closed)
Patch Set: Fix unit tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
index 9a516e85981669d1d7be8ad3b2b2f8de942ffc8d..12fbebb1679c4e082396bf19bc8e96c954389985 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8ScriptRunner.h
@@ -53,35 +53,32 @@ class CORE_EXPORT V8ScriptRunner final {
public:
// For the following methods, the caller sites have to hold
// a HandleScope and a ContextScope.
- static v8::MaybeLocal<v8::Script> compileScript(
- const ScriptSourceCode&,
- v8::Isolate*,
- AccessControlStatus = SharableCrossOrigin,
- V8CacheOptions = V8CacheOptionsDefault);
- static v8::MaybeLocal<v8::Script> compileScript(
- const String&,
- const String& fileName,
- const String& sourceMapUrl,
- const TextPosition&,
- v8::Isolate*,
- CachedMetadataHandler* = nullptr,
- AccessControlStatus = SharableCrossOrigin,
- V8CacheOptions = V8CacheOptionsDefault);
+ static v8::MaybeLocal<v8::Script> compileScript(const ScriptSourceCode&,
+ v8::Isolate*,
+ AccessControlStatus,
+ V8CacheOptions);
+ static v8::MaybeLocal<v8::Script> compileScript(const String&,
+ const String& fileName,
+ const String& sourceMapUrl,
+ const TextPosition&,
+ v8::Isolate*,
+ CachedMetadataHandler*,
+ AccessControlStatus,
+ V8CacheOptions);
// CachedMetadataHandler is set when metadata caching is supported. For
// normal scripe resources, CachedMetadataHandler is from ScriptResource.
// For worker script, ScriptResource is null but CachedMetadataHandler may be
// set. When ScriptStreamer is set, ScriptResource must be set.
- static v8::MaybeLocal<v8::Script> compileScript(
- v8::Local<v8::String>,
- const String& fileName,
- const String& sourceMapUrl,
- const TextPosition&,
- v8::Isolate*,
- ScriptResource* = nullptr,
- ScriptStreamer* = nullptr,
- CachedMetadataHandler* = nullptr,
- AccessControlStatus = SharableCrossOrigin,
- V8CacheOptions = V8CacheOptionsDefault);
+ static v8::MaybeLocal<v8::Script> compileScript(v8::Local<v8::String>,
+ const String& fileName,
+ const String& sourceMapUrl,
+ const TextPosition&,
+ v8::Isolate*,
+ ScriptResource*,
+ ScriptStreamer*,
+ CachedMetadataHandler*,
+ AccessControlStatus,
+ V8CacheOptions);
static v8::MaybeLocal<v8::Module> compileModule(v8::Isolate*,
const String& source,
const String& fileName);
« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ScriptStreamerTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698